Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1805483002:
Refactor ScopedFocusNavigation (Closed)
DescriptionRefactor ScopedFocusNavigation
- Make the function names shorter
- Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements
BUG=531990
Committed: https://crrev.com/162018f9147e5e2abc3f17e431c1c5495768c350
Cr-Commit-Position: refs/heads/master@{#381209}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 17 (10 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805483002/1
Description was changed from ========== Refactor FocusNavigatoinScope BUG= ========== to ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it always received the same elements. ==========
Description was changed from ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it always received the same elements. ========== to ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it received the same elements. ==========
Description was changed from ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it received the same elements. ========== to ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements. ==========
hayato@chromium.org changed reviewers: + kochi@chromium.org, yuzus@chromium.org
PTAL
Description was changed from ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements. ========== to ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements ========== to ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements BUG=531990 ==========
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805483002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements BUG=531990 ========== to ========== Refactor ScopedFocusNavigation - Make the function names shorter - Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements BUG=531990 Committed: https://crrev.com/162018f9147e5e2abc3f17e431c1c5495768c350 Cr-Commit-Position: refs/heads/master@{#381209} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/162018f9147e5e2abc3f17e431c1c5495768c350 Cr-Commit-Position: refs/heads/master@{#381209} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
