Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1804943002:
Remove a wrong assert and use Document directly, instead of documentElement() (Closed)
DescriptionRemove a wrong assert and use Document directly, instead of documentElement()
This is a probable fix for a beta blocker.
See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details.
BUG=594841
TEST=None. I can not find any reproducible test yet.
Committed: https://crrev.com/3ac05cb1c3012927260de6e50a36d525949346f7
Cr-Commit-Position: refs/heads/master@{#381202}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 20 (11 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804943002/1
hayato@chromium.org changed reviewers: + kochi@chromium.org, yuzus@chromium.org
PTAL
Description was changed from ========== Remove a wrong assert and use Document directly, instead of documentElement() This is a probable fix for a beta blocker. See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details. BUG==592840 ========== to ========== Remove a wrong assert and use Document directly, instead of documentElement() This is a probable fix for a beta blocker. See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details. BUG=592840 TEST=None. I can not find any reproducible test yet. ==========
lgtm
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804943002/1
The CQ bit was unchecked by hayato@chromium.org
Description was changed from ========== Remove a wrong assert and use Document directly, instead of documentElement() This is a probable fix for a beta blocker. See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details. BUG=592840 TEST=None. I can not find any reproducible test yet. ========== to ========== Remove a wrong assert and use Document directly, instead of documentElement() This is a probable fix for a beta blocker. See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details. BUG=594841 TEST=None. I can not find any reproducible test yet. ==========
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804943002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804943002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove a wrong assert and use Document directly, instead of documentElement() This is a probable fix for a beta blocker. See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details. BUG=594841 TEST=None. I can not find any reproducible test yet. ========== to ========== Remove a wrong assert and use Document directly, instead of documentElement() This is a probable fix for a beta blocker. See the comment https://bugs.chromium.org/p/chromium/issues/detail?id=594841#c14 for details. BUG=594841 TEST=None. I can not find any reproducible test yet. Committed: https://crrev.com/3ac05cb1c3012927260de6e50a36d525949346f7 Cr-Commit-Position: refs/heads/master@{#381202} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3ac05cb1c3012927260de6e50a36d525949346f7 Cr-Commit-Position: refs/heads/master@{#381202} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
