Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18054014: Remove SVGTests related code from SVGGraphicsElement subclasses (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, pdr, eae+blinkwatch, Stephen Chennney, f(malita), dglazkov+blink, lgombos
Visibility:
Public.

Description

Remove SVGTests related code from SVGGraphicsElement subclasses Remove SVGTests related code from SVGGraphicsElement subclasses and it add to the SVGGraphicsElement class instead. SVGGraphicsElement is the one subclassing SVGTests after r153166. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -75 lines) Patch
M Source/core/svg/SVGAElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGDefsElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGGElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGLineElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
do-not-use
7 years, 5 months ago (2013-06-28 12:15:54 UTC) #1
haraken
Looks reasonable. LGTM.
7 years, 5 months ago (2013-06-28 12:18:07 UTC) #2
Stephen Chennney
lgtm
7 years, 5 months ago (2013-06-28 15:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18054014/1
7 years, 5 months ago (2013-06-28 15:04:29 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 16:22:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 153248

Powered by Google App Engine
This is Rietveld 408576698