Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 18054002: Refactor HInferRepresentation into an HPhase and use the phase zone. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Refactor HInferRepresentation into an HPhase and use the phase zone. Rename HInferRepresentation to HInferRepresentationPhase, following naming scheme suggested by danno@chromium.org in https://codereview.chromium.org/17458002 The HInferRepresentationPhase now uses the phase zone for all its allocations. Depends on https://codereview.chromium.org/17587008 R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15373

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename hydrogen-phase.{cc,h} to hydrogen-infer-representation.{cc,h} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -206 lines) Patch
M src/hydrogen.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
M src/hydrogen.cc View 1 3 chunks +2 lines, -145 lines 0 comments Download
A + src/hydrogen-infer-representation.h View 1 2 chunks +18 lines, -22 lines 0 comments Download
A src/hydrogen-infer-representation.cc View 1 1 chunk +173 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 9 chunks +11 lines, -11 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 9 chunks +10 lines, -9 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-06-27 10:57:34 UTC) #1
danno
https://codereview.chromium.org/18054002/diff/1/src/hydrogen-phases.h File src/hydrogen-phases.h (right): https://codereview.chromium.org/18054002/diff/1/src/hydrogen-phases.h#newcode37 src/hydrogen-phases.h:37: class HInferRepresentationPhase : public HPhase { For GVN, we ...
7 years, 5 months ago (2013-06-27 13:45:30 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/18054002/diff/1/src/hydrogen-phases.h File src/hydrogen-phases.h (right): https://codereview.chromium.org/18054002/diff/1/src/hydrogen-phases.h#newcode37 src/hydrogen-phases.h:37: class HInferRepresentationPhase : public HPhase { On 2013/06/27 13:45:30, ...
7 years, 5 months ago (2013-06-27 19:50:57 UTC) #3
danno
lgtm
7 years, 5 months ago (2013-06-27 20:52:36 UTC) #4
Benedikt Meurer
7 years, 5 months ago (2013-06-28 07:40:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15373 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698