Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 17587008: Refactor Hydrogen environment liveness analysis into an HPhase. (Closed)

Created:
7 years, 6 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
danno
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Refactor Hydrogen environment liveness analysis into an HPhase. Rename EnvironmentSlotLivenessAnalyzer to HEnvironmentLivenessAnalysisPhase, following naming scheme suggested by danno@chromium.org in https://codereview.chromium.org/17458002 The environment slot liveness analysis now uses the phase zone for all its allocations. Depends on https://codereview.chromium.org/18034003 R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15356

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased on https://codereview.chromium.org/18034003 #

Patch Set 3 : Add DISALLOW_COPY_AND_ASSIGN to HEnvironmentLivenessAnalysisPhase #

Patch Set 4 : Turn pre-condition of HEnvironmentLivenessAnalysisPhase::Run() into an ASSERT #

Patch Set 5 : No need to allocate worklist and live bit vectors in zone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -82 lines) Patch
M src/hydrogen.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/hydrogen-environment-liveness.h View 1 2 3 chunks +10 lines, -15 lines 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 2 3 4 9 chunks +55 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Benedikt Meurer
7 years, 6 months ago (2013-06-24 06:44:44 UTC) #1
Benedikt Meurer (Google)
7 years, 6 months ago (2013-06-24 06:45:01 UTC) #2
Benedikt Meurer (Google)
7 years, 6 months ago (2013-06-24 06:48:13 UTC) #3
danno
https://codereview.chromium.org/17587008/diff/1/src/hydrogen-environment-liveness.cc File src/hydrogen-environment-liveness.cc (right): https://codereview.chromium.org/17587008/diff/1/src/hydrogen-environment-liveness.cc#newcode38 src/hydrogen-environment-liveness.cc:38: Zone* phase_zone) This should take an CompilationInfo rather than ...
7 years, 6 months ago (2013-06-24 12:11:21 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/17587008/diff/1/src/hydrogen-environment-liveness.cc File src/hydrogen-environment-liveness.cc (right): https://codereview.chromium.org/17587008/diff/1/src/hydrogen-environment-liveness.cc#newcode38 src/hydrogen-environment-liveness.cc:38: Zone* phase_zone) On 2013/06/24 12:11:21, danno wrote: > This ...
7 years, 6 months ago (2013-06-24 12:18:28 UTC) #5
danno
That's fine, but it's sometimes useful to include dependencies in the comment (e.g. "Depends on ...
7 years, 6 months ago (2013-06-24 12:25:56 UTC) #6
Benedikt Meurer
Rebased on https://codereview.chromium.org/18034003
7 years, 5 months ago (2013-06-27 09:13:11 UTC) #7
danno
lgtm
7 years, 5 months ago (2013-06-27 12:59:40 UTC) #8
Benedikt Meurer
7 years, 5 months ago (2013-06-27 13:15:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 manually as r15356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698