cc: Impl thread scroll on ScrollNode instead of LayerImpl

cc: Impl thread scroll on ScrollNode instead of LayerImpl

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2668bea689fd4a5ce07011903bca095aaf67bb07
Cr-Commit-Position: refs/heads/master@{#381614}

[sunxd, 2016-03-16 20:23:41]

Description was changed from

==========
cc: Impl thread scroll on ScrollNode instead of LayerImpl

BUG=568830
==========

to

==========
cc: Impl thread scroll on ScrollNode instead of LayerImpl

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-03-16 21:02:17]

sunxd@chromium.org changed reviewers:
+ ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org

[sunxd, 2016-03-16 21:02:18]

The change still keeps LayerImpl::ScrollBy, but it is redirected to use
ScrollTree::ScrollBy, and only used by unit tests, and viewport scrolls.

Viewport scrolling uses LayerImpl::ScrollBy because when viewport layers are
retrieved from LayerTreeHostImpl, they are already LayerImpl, so it makes no
sense to avoid LayerImpl in this case..

[ajuma, 2016-03-16 21:49:24]

https://codereview.chromium.org/1805343006/diff/40001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1805343006/diff/40001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:456: if
(!layer_tree_impl_->property_trees()->needs_rebuild && layer_tree_impl_ &&
Horizontal/vertical scrollability should never change on the compositor thread
outside of tests, so rather than trying to update the scroll tree here, tests
that want to change this should just rebuild property trees.

https://codereview.chromium.org/1805343006/diff/40001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/1805343006/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:1669: // a layer other than this one, prevent the
scroll from
"a node"

https://codereview.chromium.org/1805343006/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:1670: // propagating to this layer.
"this node"

[sunxd, 2016-03-16 23:30:23]

https://codereview.chromium.org/1805343006/diff/40001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1805343006/diff/40001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:456: if
(!layer_tree_impl_->property_trees()->needs_rebuild && layer_tree_impl_ &&
On 2016/03/16 21:49:24, ajuma wrote:
> Horizontal/vertical scrollability should never change on the compositor thread
> outside of tests, so rather than trying to update the scroll tree here, tests
> that want to change this should just rebuild property trees.

Done.

https://codereview.chromium.org/1805343006/diff/40001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/1805343006/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:1669: // a layer other than this one, prevent the
scroll from
On 2016/03/16 21:49:24, ajuma wrote:
> "a node"

Done.

https://codereview.chromium.org/1805343006/diff/40001/cc/trees/property_tree....
cc/trees/property_tree.cc:1670: // propagating to this layer.
On 2016/03/16 21:49:24, ajuma wrote:
> "this node"

Done.

[ajuma, 2016-03-16 23:40:08]

Thanks, lgtm.

[sunxd, 2016-03-16 23:42:28]

The CQ bit was checked by sunxd@chromium.org

[commit-bot: I haz the power, 2016-03-16 23:42:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805343006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805343006/60001

[commit-bot: I haz the power, 2016-03-17 00:49:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-17 00:51:11]

Description was changed from

==========
cc: Impl thread scroll on ScrollNode instead of LayerImpl

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Impl thread scroll on ScrollNode instead of LayerImpl

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2668bea689fd4a5ce07011903bca095aaf67bb07
Cr-Commit-Position: refs/heads/master@{#381614}
==========

[commit-bot: I haz the power, 2016-03-17 00:51:12]

Patchset 4 (id:??) landed as
https://crrev.com/2668bea689fd4a5ce07011903bca095aaf67bb07
Cr-Commit-Position: refs/heads/master@{#381614}