cc/layers/layer_impl_unittest.cc - Issue 1805343006: cc: Impl thread scroll on ScrollNode instead of LayerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl_unittest.cc

Issue 1805343006: cc: Impl thread scroll on ScrollNode instead of LayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer_impl_unittest.cc

diff --git a/cc/layers/layer_impl_unittest.cc b/cc/layers/layer_impl_unittest.cc

index 15d8e945b7bc6ca70a47c8062c7f25b121239fca..e88d007d2f842ea1c961d158c75a0d37ba60c170 100644

--- a/cc/layers/layer_impl_unittest.cc

+++ b/cc/layers/layer_impl_unittest.cc

@@ -633,6 +633,8 @@ TEST_F(LayerImplScrollTest, ScrollUserUnscrollableLayer) {

gfx::Vector2dF scroll_delta(20.5f, 8.5f);

layer()->set_user_scrollable_vertical(false);

+ layer()->layer_tree_impl()->property_trees()->needs_rebuild = true;

+ layer()->layer_tree_impl()->BuildPropertyTreesForTesting();

scroll_tree(layer())->UpdateScrollOffsetBaseForTesting(layer()->id(),

scroll_offset);

gfx::Vector2dF unscrolled = layer()->ScrollBy(scroll_delta);

« no previous file with comments | « cc/layers/layer_impl.cc ('k') | cc/layers/viewport.cc » ('j') | no next file with comments »