Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: components/test_runner/test_runner.cc

Issue 1805243002: Make test_runner::LayoutDumpFlags an internal detail of components/test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-mock-screen-orientation-dep
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_runner.h ('k') | components/test_runner/web_test_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 571ffb0f8d1351077e3e80c0c83d69e6640f7360..5ef5b5ea211cc547a23d1d07d8ee0c323bf2ca29 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -15,6 +15,7 @@
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "components/test_runner/app_banner_client.h"
+#include "components/test_runner/layout_dump.h"
#include "components/test_runner/mock_credential_manager_client.h"
#include "components/test_runner/mock_screen_orientation_client.h"
#include "components/test_runner/mock_web_speech_recognizer.h"
@@ -1836,9 +1837,14 @@ void TestRunner::GetAudioData(std::vector<unsigned char>* buffer_view) const {
*buffer_view = audio_data_;
}
-const LayoutDumpFlags& TestRunner::GetLayoutDumpFlags() {
+bool TestRunner::IsRecursiveLayoutDumpRequested() {
CheckResponseMimeType();
- return layout_dump_flags_;
+ return layout_dump_flags_.dump_child_frames();
+}
+
+std::string TestRunner::DumpLayout(blink::WebLocalFrame* frame) {
+ CheckResponseMimeType();
+ return ::test_runner::DumpLayout(frame, layout_dump_flags_);
}
void TestRunner::ReplicateLayoutDumpFlagsChanges(
« no previous file with comments | « components/test_runner/test_runner.h ('k') | components/test_runner/web_test_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698