Implement JsMethodMirror.parameters.

Implement JsMethodMirror.parameters and returnType.

BUG=http://dartbug.com/11513
R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24580

[kasperl, 2013-06-28 10:18:09]

LGTM.

https://codereview.chromium.org/18052004/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/18052004/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3289: ()
=> (globalMetadata..add(string)).length - 1);
I think this is a little bit hard to read.

https://codereview.chromium.org/18052004/diff/2001/dart/tests/lib/mirrors/str...
File dart/tests/lib/mirrors/stringify.dart (right):

https://codereview.chromium.org/18052004/diff/2001/dart/tests/lib/mirrors/str...
dart/tests/lib/mirrors/stringify.dart:17: var buffer = new StringBuffer('{');
Nit: Consider using an empty string buffer and end with:

   return "{$buffer}";

Same "trick" applies in multiple places in this file.

[ahe, 2013-06-28 11:07:11]

Thank you, Kasper!

https://codereview.chromium.org/18052004/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/18052004/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3289: ()
=> (globalMetadata..add(string)).length - 1);
On 2013/06/28 10:18:09, kasperl wrote:
> I think this is a little bit hard to read.

Done.

https://codereview.chromium.org/18052004/diff/2001/dart/tests/lib/mirrors/str...
File dart/tests/lib/mirrors/stringify.dart (right):

https://codereview.chromium.org/18052004/diff/2001/dart/tests/lib/mirrors/str...
dart/tests/lib/mirrors/stringify.dart:17: var buffer = new StringBuffer('{');
On 2013/06/28 10:18:09, kasperl wrote:
> Nit: Consider using an empty string buffer and end with:
> 
>    return "{$buffer}";
> 
> Same "trick" applies in multiple places in this file.

Done.

[ahe, 2013-06-28 11:08:09]

Committed patchset #2 manually as r24580 (presubmit successful).

[ngeoffray, 2013-07-12 09:16:54]

DBC

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:90: final
List<String> globalMetadata = [];
<String>[]

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:176: new
JsMethodMirror.fromUnmangledName(
Line 176 fits in line 175?

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:432: new
JsMethodMirror.fromUnmangledName(
ditto

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:758: metadata; // Compute _parameters
as a side-effect of extracting metadata.
Maybe add a computeMetadata method instead of having to comment why you're doing
a getter access.

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:765: metadata; // Compute _returnType
as a side-effect of extracting metadata.
ditto

https://codereview.chromium.org/18052004/diff/9001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:837: int index =
source.lastIndexOf(new RegExp('"[0-9,]*";?[ \n\r]*}'));
Please add a comment on what you're doing here.