Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2255)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/sdk/lib/_internal/lib/js_rti.dart

Issue 18052004: Implement JsMethodMirror.parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/sdk/lib/_internal/lib/js_mirrors.dart ('K') | « dart/sdk/lib/_internal/lib/js_mirrors.dart ('k') | dart/sdk/lib/mirrors/mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/lib/js_rti.dart
diff --git a/dart/sdk/lib/_internal/lib/js_rti.dart b/dart/sdk/lib/_internal/lib/js_rti.dart
index 01d8aceb40e21329c9adc14a41a8c425d8b60e82..4441214b8e9de4386f3a08042c4de780eca502f0 100644
--- a/dart/sdk/lib/_internal/lib/js_rti.dart
+++ b/dart/sdk/lib/_internal/lib/js_rti.dart
@@ -132,9 +132,11 @@ String runtimeTypeToString(var type) {
} else if (isJsArray(type)) {
// A list representing a type with arguments.
return getRuntimeTypeAsString(type);
- } else {
+ } else if (isJsFunction(type)) {
// A reference to the constructor.
return getConstructorName(type);
+ } else {
+ return null;
}
}
« dart/sdk/lib/_internal/lib/js_mirrors.dart ('K') | « dart/sdk/lib/_internal/lib/js_mirrors.dart ('k') | dart/sdk/lib/mirrors/mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698