Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: Source/core/rendering/RenderTableSection.h

Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTableSection.h
diff --git a/Source/core/rendering/RenderTableSection.h b/Source/core/rendering/RenderTableSection.h
index 41c2359fa9400734224f7a3ab19a40c338b7febf..e967a9039db9234966468d7d17018a8ed8dc671a 100644
--- a/Source/core/rendering/RenderTableSection.h
+++ b/Source/core/rendering/RenderTableSection.h
@@ -126,6 +126,18 @@ public:
Length logicalHeight;
};
+ struct SpanningRowsHeight {
Julien - ping for review 2013/07/16 17:22:13 It should probably be WTF_MAKE_NONCOPYABLE as we d
+ SpanningRowsHeight()
+ : totalRowsHeight(0)
+ , spanningCellHeightIgnoringBorderSpacing(0)
+ {
+ }
+
+ Vector<int> rowHeight;
+ int totalRowsHeight;
+ int spanningCellHeightIgnoringBorderSpacing;
+ };
+
const BorderValue& borderAdjoiningTableStart() const
{
if (hasSameDirectionAs(table()))
@@ -232,6 +244,10 @@ private:
void ensureRows(unsigned);
+ void calcRowsHeightInRowSpan(RenderTableCell*, struct SpanningRowsHeight&);
+ void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int, int&);
+ void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vector<int>&);
+ void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int&, Vector<int>&);
void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells);
void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent);

Powered by Google App Engine
This is Rietveld 408576698