LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html - Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

diff --git a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

index 804067b22d60325e77c5f5fdb318cb72abe694e6..da79e3d5352e5fee63d842792a919a14c9af3933 100644

--- a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

+++ b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

@@ -75,7 +75,7 @@

</tr>

- <tr data-expected-height="76">

+ <tr data-expected-height="78">

</tr>

@@ -90,17 +90,17 @@

<tr>

</tr>

- <tr data-expected-height="33">

+ <tr data-expected-height="59">

<td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td>

</tr>

- <tr data-expected-height="130">

+ <tr data-expected-height="74">

</tr>

- <tr data-expected-height="43">

+ <tr data-expected-height="34">

</tr>

- <tr data-expected-height="136">

+ <tr data-expected-height="104">

</tr>

@@ -152,7 +152,7 @@

<td style="vertical-align:super">row4 col1 vertical-align=super</td>

</tr>

- <tr data-expected-height="91">

+ <tr data-expected-height="92">

<td style="vertical-align:text-bottom">row5 col1 vertical-align=text-bottom</td>

</tr>

@@ -223,7 +223,7 @@

</tr>

- <tr data-expected-height="60">

+ <tr data-expected-height="61">