Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Table rowspan</title> 4 <title>Table rowspan</title>
5 <script src="../../resources/check-layout.js"></script> 5 <script src="../../resources/check-layout.js"></script>
6 <style> 6 <style>
7 td { font: 15px/1 Ahem } 7 td { font: 15px/1 Ahem }
8 #div-table { display: table; border-spacing: 2px } 8 #div-table { display: table; border-spacing: 2px }
9 #div-row, #span-row { display: table-row } 9 #div-row, #span-row { display: table-row }
10 #div-cell, #span-cell { display: table-cell } 10 #div-cell, #span-cell { display: table-cell }
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 <tr data-expected-height="57"> 68 <tr data-expected-height="57">
69 <td>row1 col0</td> 69 <td>row1 col0</td>
70 <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td> 70 <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td>
71 </tr> 71 </tr>
72 <tr data-expected-height="57"> 72 <tr data-expected-height="57">
73 <td>row2 col0</td> 73 <td>row2 col0</td>
74 </tr> 74 </tr>
75 <tr data-expected-height="74"> 75 <tr data-expected-height="74">
76 <td>row3 col0</td> 76 <td>row3 col0</td>
77 </tr> 77 </tr>
78 <tr data-expected-height="76"> 78 <tr data-expected-height="78">
79 <td>row4 col0</td> 79 <td>row4 col0</td>
80 </tr> 80 </tr>
81 <tr data-expected-height="19"> 81 <tr data-expected-height="19">
82 <td>row5 col0</td> 82 <td>row5 col0</td>
83 <td>row5 col1</td> 83 <td>row5 col1</td>
84 </tr> 84 </tr>
85 </tbody> 85 </tbody>
86 </table> 86 </table>
87 <h5>Test 4 - One rowSpan cell and specified cells height</h5> 87 <h5>Test 4 - One rowSpan cell and specified cells height</h5>
88 <table border="1"> 88 <table border="1">
89 <tbody> 89 <tbody>
90 <tr> 90 <tr>
91 <td>row0 col0</td> 91 <td>row0 col0</td>
92 </tr> 92 </tr>
93 <tr data-expected-height="33"> 93 <tr data-expected-height="59">
94 <td>row1 col0</td> 94 <td>row1 col0</td>
95 <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td> 95 <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td>
96 </tr> 96 </tr>
97 <tr data-expected-height="130"> 97 <tr data-expected-height="74">
98 <td style="height:70px">row2 col0</td> 98 <td style="height:70px">row2 col0</td>
99 </tr> 99 </tr>
100 <tr data-expected-height="43"> 100 <tr data-expected-height="34">
101 <td style="height:30px">row3 col0</td> 101 <td style="height:30px">row3 col0</td>
102 </tr> 102 </tr>
103 <tr data-expected-height="136"> 103 <tr data-expected-height="104">
104 <td style="height:100px">row4 col0</td> 104 <td style="height:100px">row4 col0</td>
105 </tr> 105 </tr>
106 <tr data-expected-height="54"> 106 <tr data-expected-height="54">
107 <td style="height:50px">row5 col0</td> 107 <td style="height:50px">row5 col0</td>
108 <td>row5 col1</td> 108 <td>row5 col1</td>
109 </tr> 109 </tr>
110 </tbody> 110 </tbody>
111 </table> 111 </table>
112 <h5>Test 5 - RowSpan and ColSpan. </h5> 112 <h5>Test 5 - RowSpan and ColSpan. </h5>
113 <table border="1" width="607"> 113 <table border="1" width="607">
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 <tr data-expected-height="77"> 145 <tr data-expected-height="77">
146 <td rowspan="4" style="vertical-align:text-top; height:300px">row2 col0 - rowspan=4 vertical-align=text-top</td> 146 <td rowspan="4" style="vertical-align:text-top; height:300px">row2 col0 - rowspan=4 vertical-align=text-top</td>
147 <td style="vertical-align:sub">row2 col1 vertical-align=sub</td> 147 <td style="vertical-align:sub">row2 col1 vertical-align=sub</td>
148 </tr> 148 </tr>
149 <tr data-expected-height="77"> 149 <tr data-expected-height="77">
150 <td style="vertical-align:middle">row3 col1 vertical-align=middle</td> 150 <td style="vertical-align:middle">row3 col1 vertical-align=middle</td>
151 </tr> 151 </tr>
152 <tr data-expected-height="69"> 152 <tr data-expected-height="69">
153 <td style="vertical-align:super">row4 col1 vertical-align=super</td> 153 <td style="vertical-align:super">row4 col1 vertical-align=super</td>
154 </tr> 154 </tr>
155 <tr data-expected-height="91"> 155 <tr data-expected-height="92">
156 <td style="vertical-align:text-bottom">row5 col1 vertical-align=text-botto m</td> 156 <td style="vertical-align:text-bottom">row5 col1 vertical-align=text-botto m</td>
157 </tr> 157 </tr>
158 <tr data-expected-height="19"> 158 <tr data-expected-height="19">
159 <td>row6 col0</td> 159 <td>row6 col0</td>
160 </tr> 160 </tr>
161 </tbody> 161 </tbody>
162 </table> 162 </table>
163 <h5>Test 7 - CSS Table.</h5> 163 <h5>Test 7 - CSS Table.</h5>
164 <div id="div-table"> 164 <div id="div-table">
165 <span id="span-row"> 165 <span id="span-row">
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 <td rowspan=3 style="height:200px">row1 col1</td> 216 <td rowspan=3 style="height:200px">row1 col1</td>
217 <td rowspan=2 style="height:100px">row1 col2</td> 217 <td rowspan=2 style="height:100px">row1 col2</td>
218 <td>row1 col3</td> 218 <td>row1 col3</td>
219 </tr> 219 </tr>
220 <tr data-expected-height="47"> 220 <tr data-expected-height="47">
221 <td>row2 col3</td> 221 <td>row2 col3</td>
222 </tr> 222 </tr>
223 <tr data-expected-height="59"> 223 <tr data-expected-height="59">
224 <td>row3 col2</td> 224 <td>row3 col2</td>
225 </tr> 225 </tr>
226 <tr data-expected-height="60"> 226 <tr data-expected-height="61">
227 <td>row4 col1</td> 227 <td>row4 col1</td>
228 <td>row4 col2</td> 228 <td>row4 col2</td>
229 <td>row4 col3</td> 229 <td>row4 col3</td>
230 </tr> 230 </tr>
231 <tr data-expected-height="19"> 231 <tr data-expected-height="19">
232 <td>row5 col0</td> 232 <td>row5 col0</td>
233 <td>row5 col1</td> 233 <td>row5 col1</td>
234 <td>row5 col2</td> 234 <td>row5 col2</td>
235 </tr> 235 </tr>
236 <tr data-expected-height="0"> 236 <tr data-expected-height="0">
237 <td rowspan=5 style="height:200px">row6 col0</td> 237 <td rowspan=5 style="height:200px">row6 col0</td>
238 <td rowspan=5 style="height:100px">row6 col1</td> 238 <td rowspan=5 style="height:100px">row6 col1</td>
239 </tr> 239 </tr>
240 <tr data-expected-height="19"> 240 <tr data-expected-height="19">
241 <td>row7 col1</td> 241 <td>row7 col1</td>
242 </tr> 242 </tr>
243 <tr data-expected-height="19"> 243 <tr data-expected-height="19">
244 <td>row8 col1</td> 244 <td>row8 col1</td>
245 </tr> 245 </tr>
246 <tr data-expected-height="19"> 246 <tr data-expected-height="19">
247 <td>row9 col1</td> 247 <td>row9 col1</td>
248 </tr> 248 </tr>
249 <tr data-expected-height="19"> 249 <tr data-expected-height="19">
250 <td>row10 col1</td> 250 <td>row10 col1</td>
251 </tr> 251 </tr>
252 </table> 252 </table>
253 </body> 253 </body>
254 </html> 254 </html>
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698