third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp - Issue 1804963005: Avoid paintInvalidationContainer parameter of invalidatePaintIfNeeded()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp

Issue 1804963005: Avoid paintInvalidationContainer parameter of invalidatePaintIfNeeded() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp

index 243a47ac57576abfcae703a830d47875511ff8da..9e57cfbd0c3fa7109eca3fd5b005475fa1252869 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp

@@ -130,7 +130,7 @@ IntRect LayoutSVGModelObject::absoluteElementBoundingBoxRect() const

return localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoordinates())).enclosingBoundingBox();

}

-void LayoutSVGModelObject::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalidationState)

+void LayoutSVGModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)

{

ASSERT(!needsLayout());

@@ -139,11 +139,12 @@ void LayoutSVGModelObject::invalidateTreeIfNeeded(PaintInvalidationState& paintI

if (!shouldCheckForPaintInvalidation(paintInvalidationState))

return;

- invalidatePaintIfNeeded(paintInvalidationState, paintInvalidationState.paintInvalidationContainer());

- clearPaintInvalidationState(paintInvalidationState);

+ PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *this);

+ invalidatePaintIfNeeded(newPaintInvalidationState);

+ clearPaintInvalidationFlags(newPaintInvalidationState);

- PaintInvalidationState childPaintInvalidationState(paintInvalidationState, *this);

- invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState);

+ newPaintInvalidationState.updatePaintOffsetAndClipForChildren();

+ invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);

}

} // namespace blink