Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: src/elements.h

Issue 1804963002: [builtins] Fix Array.prototype.concat bug (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing nits and reverting to old scheme Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ELEMENTS_H_ 5 #ifndef V8_ELEMENTS_H_
6 #define V8_ELEMENTS_H_ 6 #define V8_ELEMENTS_H_
7 7
8 #include "src/elements-kind.h" 8 #include "src/elements-kind.h"
9 #include "src/heap/heap.h" 9 #include "src/heap/heap.h"
10 #include "src/isolate.h" 10 #include "src/isolate.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 PropertyFilter filter = ALL_PROPERTIES) = 0; 48 PropertyFilter filter = ALL_PROPERTIES) = 0;
49 49
50 inline bool HasElement(Handle<JSObject> holder, uint32_t index, 50 inline bool HasElement(Handle<JSObject> holder, uint32_t index,
51 PropertyFilter filter = ALL_PROPERTIES) { 51 PropertyFilter filter = ALL_PROPERTIES) {
52 return HasElement(holder, index, handle(holder->elements()), filter); 52 return HasElement(holder, index, handle(holder->elements()), filter);
53 } 53 }
54 54
55 virtual Handle<Object> Get(Handle<JSObject> holder, uint32_t entry) = 0; 55 virtual Handle<Object> Get(Handle<JSObject> holder, uint32_t entry) = 0;
56 56
57 virtual PropertyDetails GetDetails(JSObject* holder, uint32_t entry) = 0; 57 virtual PropertyDetails GetDetails(JSObject* holder, uint32_t entry) = 0;
58 virtual bool HasAccessors(JSObject* holder) = 0;
58 59
59 // Modifies the length data property as specified for JSArrays and resizes the 60 // Modifies the length data property as specified for JSArrays and resizes the
60 // underlying backing store accordingly. The method honors the semantics of 61 // underlying backing store accordingly. The method honors the semantics of
61 // changing array sizes as defined in EcmaScript 5.1 15.4.5.2, i.e. array that 62 // changing array sizes as defined in EcmaScript 5.1 15.4.5.2, i.e. array that
62 // have non-deletable elements can only be shrunk to the size of highest 63 // have non-deletable elements can only be shrunk to the size of highest
63 // element that is non-deletable. 64 // element that is non-deletable.
64 virtual void SetLength(Handle<JSArray> holder, uint32_t new_length) = 0; 65 virtual void SetLength(Handle<JSArray> holder, uint32_t new_length) = 0;
65 66
66 // Deletes an element in an object. 67 // Deletes an element in an object.
67 virtual void Delete(Handle<JSObject> holder, uint32_t entry) = 0; 68 virtual void Delete(Handle<JSObject> holder, uint32_t entry) = 0;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 bool allow_appending = false); 186 bool allow_appending = false);
186 187
187 MUST_USE_RESULT MaybeHandle<Object> ArrayConstructInitializeElements( 188 MUST_USE_RESULT MaybeHandle<Object> ArrayConstructInitializeElements(
188 Handle<JSArray> array, 189 Handle<JSArray> array,
189 Arguments* args); 190 Arguments* args);
190 191
191 } // namespace internal 192 } // namespace internal
192 } // namespace v8 193 } // namespace v8
193 194
194 #endif // V8_ELEMENTS_H_ 195 #endif // V8_ELEMENTS_H_
OLDNEW
« src/builtins.cc ('K') | « src/builtins.cc ('k') | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698