Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1804763002:
Use monotonic raw timestamp by default except for x86/64 (Closed)
|
Created:
4 years, 9 months ago by mengyu Modified:
4 years, 9 months ago CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse monotonic raw timestamp by default except for x86/64
use_alsa_monotonic_raw_tstamps flag should be set to true for
all audio products since alsa-lib is upgraded to 1.0.29 which
added monotonic raw timestamp feature. Setting it to true so
we don't need to add this flag to every internal audio targets
and C4A partners.
BUG=internal b/27654854
TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type
is called.
Committed: https://crrev.com/b081d95c143279c2a3ede08bebc6ae70c5c234e4
Cr-Commit-Position: refs/heads/master@{#381534}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Total comments: 4
Patch Set 3 : #Patch Set 4 : #Messages
Total messages: 26 (10 generated)
Description was changed from ========== Use monotonic raw timestamp by default except for x86/64 use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. ========== to ========== Use monotonic raw timestamp by default except for x86/64 use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. ==========
mengyu@chromium.org changed reviewers: + jyw@chromium.org, kmackay@chromium.org, slan@chromium.org, wzhong@chromium.org
https://codereview.chromium.org/1804763002/diff/1/chromecast/media/cma/backen... File chromecast/media/cma/backend/alsa/BUILD.gn (right): https://codereview.chromium.org/1804763002/diff/1/chromecast/media/cma/backen... chromecast/media/cma/backend/alsa/BUILD.gn:14: if (target_cpu != "x86" && target_cpu != "x64") { if (!is_cast_desktop_build)
mengyu@chromium.org changed reviewers: + mengyu@chromium.org
https://codereview.chromium.org/1804763002/diff/1/chromecast/media/cma/backen... File chromecast/media/cma/backend/alsa/BUILD.gn (right): https://codereview.chromium.org/1804763002/diff/1/chromecast/media/cma/backen... chromecast/media/cma/backend/alsa/BUILD.gn:14: if (target_cpu != "x86" && target_cpu != "x64") { On 2016/03/16 16:27:02, kmackay wrote: > if (!is_cast_desktop_build) Done.
https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... File chromecast/media/cma/backend/alsa/BUILD.gn (right): https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... chromecast/media/cma/backend/alsa/BUILD.gn:14: if (!is_cast_desktop_build) { This condition is not needed, please just declare it like this: use_alsa_monotonic_raw_tstamps = !is_cast_desktop_build
https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... File chromecast/media/cma/backend/alsa/BUILD.gn (right): https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... chromecast/media/cma/backend/alsa/BUILD.gn:14: if (!is_cast_desktop_build) { On 2016/03/16 16:55:26, slan wrote: > This condition is not needed, please just declare it like this: > > use_alsa_monotonic_raw_tstamps = !is_cast_desktop_build P.S. For good style, let's add this to the top: import("//build/config/chromecast_build.gni") This is recursively imported via media_options.gni, but I think Include What You Use is a good policy here.
https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... File chromecast/media/cma/backend/alsa/BUILD.gn (right): https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... chromecast/media/cma/backend/alsa/BUILD.gn:14: if (!is_cast_desktop_build) { On 2016/03/16 16:55:26, slan wrote: > This condition is not needed, please just declare it like this: > > use_alsa_monotonic_raw_tstamps = !is_cast_desktop_build Done.
https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... File chromecast/media/cma/backend/alsa/BUILD.gn (right): https://codereview.chromium.org/1804763002/diff/20001/chromecast/media/cma/ba... chromecast/media/cma/backend/alsa/BUILD.gn:14: if (!is_cast_desktop_build) { On 2016/03/16 16:58:47, slan wrote: > On 2016/03/16 16:55:26, slan wrote: > > This condition is not needed, please just declare it like this: > > > > use_alsa_monotonic_raw_tstamps = !is_cast_desktop_build > > P.S. For good style, let's add this to the top: > > import("//build/config/chromecast_build.gni") > > This is recursively imported via media_options.gni, but I think Include What You > Use is a good policy here. Done. Sorry, didn't see this import comment previously.
lgtm
lgtm
The CQ bit was checked by mengyu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804763002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by mengyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804763002/60001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm!
The CQ bit was checked by slan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804763002/60001
Message was sent while issue was closed.
Description was changed from ========== Use monotonic raw timestamp by default except for x86/64 use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. ========== to ========== Use monotonic raw timestamp by default except for x86/64 use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Use monotonic raw timestamp by default except for x86/64 use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. ========== to ========== Use monotonic raw timestamp by default except for x86/64 use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. Committed: https://crrev.com/b081d95c143279c2a3ede08bebc6ae70c5c234e4 Cr-Commit-Position: refs/heads/master@{#381534} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/b081d95c143279c2a3ede08bebc6ae70c5c234e4 Cr-Commit-Position: refs/heads/master@{#381534} |
