Remove --harmony-modules flag and let embedder decide when modules are used

Remove --harmony-modules flag and let embedder decide when modules are used

Modules already have a separate entrypoint into the engine (at the moment,
this is v8::ScriptCompiler::CompileModule, though that will change to
something like ParseModule). This meant that requiring a commandline flag
simply added an extra complexity burden on embedders. By removing the v8
flag, this lets embedders use their own flagging mechanism (such as d8's
"--module", or Blink's RuntimeEnabledFeatures) to control whether
modules are to be used.

Also remove old modules tests that were being skipped (since they test
very old, pre-ES2015 modules syntax).

R=littledan@chromium.org
BUG=v8:1569, chromium:594639
LOG=y

Committed: https://crrev.com/5a202cce6e2b2de7b6117c9a3db796b70bf440f2
Cr-Commit-Position: refs/heads/master@{#34764}

[Dan Ehrenberg, 2016-03-15 00:22:52]

lgtm

https://codereview.chromium.org/1804693002/diff/1/src/d8.cc
File src/d8.cc (left):

https://codereview.chromium.org/1804693002/diff/1/src/d8.cc#oldcode1986
src/d8.cc:1986: bool enable_harmony_modules = false;
Presumably there's no reasonable way to recover the module functionality at d8,
right? Because how would you collect the exports, and where would they go? Or
could we allow it but in a special mode where exports are banned?

[adamk, 2016-03-15 00:40:58]

https://codereview.chromium.org/1804693002/diff/1/src/d8.cc
File src/d8.cc (left):

https://codereview.chromium.org/1804693002/diff/1/src/d8.cc#oldcode1986
src/d8.cc:1986: bool enable_harmony_modules = false;
On 2016/03/15 00:22:52, Dan Ehrenberg wrote:
> Presumably there's no reasonable way to recover the module functionality at
d8,
> right? Because how would you collect the exports, and where would they go? Or
> could we allow it but in a special mode where exports are banned?

Not sure what you mean...d8 does support modules. As per the comment below, it's
just handled in a different function. The following loads a file as a module:

d8 --module foo.js

At the moment imports don't work, but I have some basic tests in
mjsunit/harmony/modules.js

[adamk, 2016-03-15 00:41:03]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-03-15 00:41:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804693002/1

[commit-bot: I haz the power, 2016-03-15 00:43:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-15 00:45:06]

Description was changed from

==========
Remove --harmony-modules flag and let embedder decide when modules are used

Modules already have a separate entrypoint into the engine (at the moment,
this is v8::ScriptCompiler::CompileModule, though that will change to
something like ParseModule). This meant that requiring a commandline flag
simply added an extra complexity burden on embedders. By removing the v8
flag, this lets embedders use their own flagging mechanism (such as d8's
"--module", or Blink's RuntimeEnabledFeatures) to control whether
modules are to be used.

Also remove old modules tests that were being skipped (since they test
very old, pre-ES2015 modules syntax).

R=littledan@chromium.org
BUG=v8:1569, chromium:594639
LOG=y
==========

to

==========
Remove --harmony-modules flag and let embedder decide when modules are used

Modules already have a separate entrypoint into the engine (at the moment,
this is v8::ScriptCompiler::CompileModule, though that will change to
something like ParseModule). This meant that requiring a commandline flag
simply added an extra complexity burden on embedders. By removing the v8
flag, this lets embedders use their own flagging mechanism (such as d8's
"--module", or Blink's RuntimeEnabledFeatures) to control whether
modules are to be used.

Also remove old modules tests that were being skipped (since they test
very old, pre-ES2015 modules syntax).

R=littledan@chromium.org
BUG=v8:1569, chromium:594639
LOG=y

Committed: https://crrev.com/5a202cce6e2b2de7b6117c9a3db796b70bf440f2
Cr-Commit-Position: refs/heads/master@{#34764}
==========

[commit-bot: I haz the power, 2016-03-15 00:45:07]

Patchset 1 (id:??) landed as
https://crrev.com/5a202cce6e2b2de7b6117c9a3db796b70bf440f2
Cr-Commit-Position: refs/heads/master@{#34764}