src/compiler.cc - Issue 1804693002: Remove --harmony-modules flag and let embedder decide when modules are used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1804693002: Remove --harmony-modules flag and let embedder decide when modules are used (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index d4e1d412e9003f5ceb9564466b49a21f57a7ccb3..aff7f48513a26e01cbc513fe9bc70ad2c106154d 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -1650,7 +1650,7 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfoForScript(

Zone zone;

ParseInfo parse_info(&zone, script);

CompilationInfo info(&parse_info);

- if (FLAG_harmony_modules && is_module) {

+ if (is_module) {

parse_info.set_module();

} else {

parse_info.set_global();

« no previous file with comments | « src/bootstrapper.cc ('k') | src/d8.cc » ('j') | src/d8.cc » ('J')