Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804563002: Refactor WebRTC certificate generation to use WebPassOwnPtr. (Closed)

Created:
4 years, 9 months ago by Guido Urdaneta
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, kinuko+watch, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor WebRTC certificate generation to use WebPassOwnPtr. BUG=594539 Committed: https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca Cr-Commit-Position: refs/heads/master@{#380984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -31 lines) Patch
M content/renderer/media/rtc_certificate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_certificate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_certificate_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_certificate_generator.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCCertificate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCCertificate.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/RTCConfiguration.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCCertificate.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebRTCCertificateGenerator.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Guido Urdaneta
Hi, PTAL
4 years, 9 months ago (2016-03-14 14:02:45 UTC) #3
Guido Urdaneta
+haraken
4 years, 9 months ago (2016-03-14 14:03:20 UTC) #5
haraken
Thanks for the quick fix! LGTM.
4 years, 9 months ago (2016-03-14 14:10:00 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-14 14:31:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804563002/1
4 years, 9 months ago (2016-03-14 14:47:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 16:13:08 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 16:14:36 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca
Cr-Commit-Position: refs/heads/master@{#380984}

Powered by Google App Engine
This is Rietveld 408576698