Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/public/platform/WebRTCCertificateGenerator.h

Issue 1804563002: Refactor WebRTC certificate generation to use WebPassOwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/WebRTCCertificate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebRTCCertificateGenerator.h
diff --git a/third_party/WebKit/public/platform/WebRTCCertificateGenerator.h b/third_party/WebKit/public/platform/WebRTCCertificateGenerator.h
index aa10f885108c35122d5c905745e7309268bf04d8..e41629ce8a7588a22ab6511321240f0abd158ed9 100644
--- a/third_party/WebKit/public/platform/WebRTCCertificateGenerator.h
+++ b/third_party/WebKit/public/platform/WebRTCCertificateGenerator.h
@@ -32,24 +32,27 @@
#define WebRTCCertificateGenerator_h
#include "public/platform/WebCallbacks.h"
+#include "public/platform/WebPassOwnPtr.h"
#include "public/platform/WebRTCCertificate.h"
#include "public/platform/WebRTCKeyParams.h"
#include "public/platform/WebURL.h"
namespace blink {
+using WebRTCCertificateCallback = WebCallbacks<WebPassOwnPtr<WebRTCCertificate>, void>;
+
// Interface defining a class that can generate WebRTCCertificates asynchronously.
class WebRTCCertificateGenerator {
public:
virtual ~WebRTCCertificateGenerator() {}
- // Start generating a certificate asynchronously. The |observer| is invoked on the
+ // Start generating a certificate asynchronously. |observer| is invoked on the
// same thread that called generateCertificate when the operation is completed.
virtual void generateCertificate(
const WebRTCKeyParams&,
const WebURL&,
const WebURL& firstPartyForCookies,
- WebCallbacks<WebRTCCertificate*, void>* observer) = 0;
+ WebPassOwnPtr<WebRTCCertificateCallback> observer) = 0;
// Determines if the parameters are supported by generateCertificate.
// For example, if the number of bits of some parameter is too small or too large we
« no previous file with comments | « third_party/WebKit/public/platform/WebRTCCertificate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698