Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2450)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 1804413004: Disable blink_perf.canvas on Android One (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index d6e99e0468a6abdf69c81ec2898c5c7489974cfd..7e9377569765b91cc2feef137f5a351d2a272e49 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -178,6 +178,11 @@ class BlinkPerfCanvas(perf_benchmark.PerfBenchmark):
test = _BlinkPerfMeasurement
@classmethod
+ def ShouldDisable(cls, possible_browser):
+ # http://crbug.com/593973: Disabled on Android One.
+ return '4560MMX' in possible_browser.platform.GetDeviceTypeName()
petrcermak 2016/03/17 13:32:41 See ro.product.model in https://build.chromium.org
Sami 2016/03/17 13:48:36 We've also used cls.IsSvelte() for things like thi
dshwang 2016/03/18 14:24:23 Does it exclude only Android One? Project Svelte
+
+ @classmethod
def Name(cls):
return 'blink_perf.canvas'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698