Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: tools/perf/benchmarks/blink_perf.py

Issue 1804413004: Disable blink_perf.canvas on Android One (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 9
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 return CreateStorySetFromPath(path, SKIPPED_FILE) 171 return CreateStorySetFromPath(path, SKIPPED_FILE)
172 172
173 173
174 @benchmark.Disabled('android-webview', # http://crbug.com/593200 174 @benchmark.Disabled('android-webview', # http://crbug.com/593200
175 'reference') # http://crbug.com/576779 175 'reference') # http://crbug.com/576779
176 class BlinkPerfCanvas(perf_benchmark.PerfBenchmark): 176 class BlinkPerfCanvas(perf_benchmark.PerfBenchmark):
177 tag = 'canvas' 177 tag = 'canvas'
178 test = _BlinkPerfMeasurement 178 test = _BlinkPerfMeasurement
179 179
180 @classmethod 180 @classmethod
181 def ShouldDisable(cls, possible_browser):
182 # http://crbug.com/593973: Disabled on Android One.
183 return '4560MMX' in possible_browser.platform.GetDeviceTypeName()
petrcermak 2016/03/17 13:32:41 See ro.product.model in https://build.chromium.org
Sami 2016/03/17 13:48:36 We've also used cls.IsSvelte() for things like thi
dshwang 2016/03/18 14:24:23 Does it exclude only Android One? Project Svelte
184
185 @classmethod
181 def Name(cls): 186 def Name(cls):
182 return 'blink_perf.canvas' 187 return 'blink_perf.canvas'
183 188
184 def CreateStorySet(self, options): 189 def CreateStorySet(self, options):
185 path = os.path.join(BLINK_PERF_BASE_DIR, 'Canvas') 190 path = os.path.join(BLINK_PERF_BASE_DIR, 'Canvas')
186 story_set = CreateStorySetFromPath( 191 story_set = CreateStorySetFromPath(
187 path, SKIPPED_FILE, 192 path, SKIPPED_FILE,
188 shared_page_state_class=( 193 shared_page_state_class=(
189 webgl_supported_shared_state.WebGLSupportedSharedState)) 194 webgl_supported_shared_state.WebGLSupportedSharedState))
190 # WebGLSupportedSharedState requires the skipped_gpus property to 195 # WebGLSupportedSharedState requires the skipped_gpus property to
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 333
329 def CreateStorySet(self, options): 334 def CreateStorySet(self, options):
330 path = os.path.join(BLINK_PERF_BASE_DIR, 'Pywebsocket') 335 path = os.path.join(BLINK_PERF_BASE_DIR, 'Pywebsocket')
331 return CreateStorySetFromPath( 336 return CreateStorySetFromPath(
332 path, SKIPPED_FILE, 337 path, SKIPPED_FILE,
333 shared_page_state_class=_SharedPywebsocketPageState) 338 shared_page_state_class=_SharedPywebsocketPageState)
334 339
335 @classmethod 340 @classmethod
336 def ShouldDisable(cls, possible_browser): 341 def ShouldDisable(cls, possible_browser):
337 return cls.IsSvelte(possible_browser) # http://crbug.com/551950 342 return cls.IsSvelte(possible_browser) # http://crbug.com/551950
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698