Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1804413004:
Disable blink_perf.canvas on Android One (Closed)
|
Created:
4 years, 9 months ago by petrcermak Modified:
4 years, 9 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable blink_perf.canvas on Android One
Rationale: The benchmark is consistently failing on the "Android One
Perf (2)" bot (see the associated bug).
BUG=593973
TBR=skyostil
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
Committed: https://crrev.com/69b38e03d4714e45603211a9b8b198d39b6e9546
Cr-Commit-Position: refs/heads/master@{#381741}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Use IsSvelte() instead #Messages
Total messages: 20 (10 generated)
Description was changed from ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 ========== to ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
petrcermak@chromium.org changed reviewers: + skyostil@chromium.org
PTAL. Thanks, Petr
https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... tools/perf/benchmarks/blink_perf.py:183: return '4560MMX' in possible_browser.platform.GetDeviceTypeName() See ro.product.model in https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%2...
Description was changed from ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 TBR=skyostil CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804413004/1
lgtm. https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... tools/perf/benchmarks/blink_perf.py:183: return '4560MMX' in possible_browser.platform.GetDeviceTypeName() On 2016/03/17 13:32:41, petrcermak wrote: > See ro.product.model in > https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%2... We've also used cls.IsSvelte() for things like this. Not sure which one is more appropriate in this particular case.
The CQ bit was unchecked by petrcermak@chromium.org
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1804413004/#ps20001 (title: "Use IsSvelte() instead")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804413004/20001
On 2016/03/17 13:48:36, Sami wrote: > lgtm. > > https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... > File tools/perf/benchmarks/blink_perf.py (right): > > https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... > tools/perf/benchmarks/blink_perf.py:183: return '4560MMX' in > possible_browser.platform.GetDeviceTypeName() > On 2016/03/17 13:32:41, petrcermak wrote: > > See ro.product.model in > > > https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%2... > > We've also used cls.IsSvelte() for things like this. Not sure which one is more > appropriate in this particular case. Good point. I changed the method to use cls.IsSvelte() instead (because it's already used in many other cases). Thanks, Petr
Message was sent while issue was closed.
Description was changed from ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 TBR=skyostil CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 TBR=skyostil CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 TBR=skyostil CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable blink_perf.canvas on Android One Rationale: The benchmark is consistently failing on the "Android One Perf (2)" bot (see the associated bug). BUG=593973 TBR=skyostil CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/69b38e03d4714e45603211a9b8b198d39b6e9546 Cr-Commit-Position: refs/heads/master@{#381741} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/69b38e03d4714e45603211a9b8b198d39b6e9546 Cr-Commit-Position: refs/heads/master@{#381741}
Message was sent while issue was closed.
dongseong.hwang@intel.com changed reviewers: + dongseong.hwang@intel.com
Message was sent while issue was closed.
https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/1804413004/diff/1/tools/perf/benchmarks/blink... tools/perf/benchmarks/blink_perf.py:183: return '4560MMX' in possible_browser.platform.GetDeviceTypeName() On 2016/03/17 13:48:36, Sami wrote: > On 2016/03/17 13:32:41, petrcermak wrote: > > See ro.product.model in > > > https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%2... > > We've also used cls.IsSvelte() for things like this. Not sure which one is more > appropriate in this particular case. Does it exclude only Android One? Project Svelte is called to certain Android version... http://developer.android.com/preview/behavior-changes.html
Message was sent while issue was closed.
On 2016/03/18 14:24:23, dshwang wrote: > Does it exclude only Android One? No, it excludes all Svelte devices like you said. We only have the One on the waterfall, and generally the test failures are triggered by the lack of memory, so it is usually fine to blanket-disable tests for all of Svelte. |
