Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tools/gn/bundle_data.h

Issue 1804263003: Consider bundle_data as public_deps of create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{interstitial}
Patch Set: Rebase on origin/master Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | tools/gn/target.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bundle_data.h
diff --git a/tools/gn/bundle_data.h b/tools/gn/bundle_data.h
index 9d1df13fe80f363665dbf5a7592234f3bf36deee..6465739885720fe6133b77120cdc58579880f0cf 100644
--- a/tools/gn/bundle_data.h
+++ b/tools/gn/bundle_data.h
@@ -9,6 +9,7 @@
#include <vector>
#include "tools/gn/bundle_file_rule.h"
+#include "tools/gn/unique_vector.h"
class OutputFile;
class SourceFile;
@@ -76,9 +77,13 @@ class BundleData {
std::string& plugins_dir() { return plugins_dir_; }
const std::string& plugins_dir() const { return plugins_dir_; }
+ UniqueVector<const Target*>& deps() { return deps_; }
brettw 2016/03/21 22:49:47 Can you call this "bundle_deps" and comment that t
sdefresne 2016/03/22 12:34:05 done.
+ const UniqueVector<const Target*>& deps() const { return deps_; }
+
private:
std::vector<SourceFile> asset_catalog_sources_;
std::vector<BundleFileRule> file_rules_;
+ UniqueVector<const Target*> deps_;
// All those values are subdirectories relative to root_build_dir, and apart
// from root_dir, they are either equal to root_dir_ or subdirectories of it.
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | tools/gn/target.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698