Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: tools/gn/bundle_data.h

Issue 1804263003: Consider bundle_data as public_deps of create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{interstitial}
Patch Set: Rebase on origin/master Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | tools/gn/target.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_BUNDLE_DATA_H_ 5 #ifndef TOOLS_GN_BUNDLE_DATA_H_
6 #define TOOLS_GN_BUNDLE_DATA_H_ 6 #define TOOLS_GN_BUNDLE_DATA_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "tools/gn/bundle_file_rule.h" 11 #include "tools/gn/bundle_file_rule.h"
12 #include "tools/gn/unique_vector.h"
12 13
13 class OutputFile; 14 class OutputFile;
14 class SourceFile; 15 class SourceFile;
15 class Settings; 16 class Settings;
16 class Target; 17 class Target;
17 18
18 // Returns true if |source| correspond to the path of a file in an asset 19 // Returns true if |source| correspond to the path of a file in an asset
19 // catalog. If defined |asset_catalog| is set to its path. 20 // catalog. If defined |asset_catalog| is set to its path.
20 // 21 //
21 // An asset catalog is an OS X bundle with the ".xcassets" extension. It 22 // An asset catalog is an OS X bundle with the ".xcassets" extension. It
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 70
70 std::string& resources_dir() { return resources_dir_; } 71 std::string& resources_dir() { return resources_dir_; }
71 const std::string& resources_dir() const { return resources_dir_; } 72 const std::string& resources_dir() const { return resources_dir_; }
72 73
73 std::string& executable_dir() { return executable_dir_; } 74 std::string& executable_dir() { return executable_dir_; }
74 const std::string& executable_dir() const { return executable_dir_; } 75 const std::string& executable_dir() const { return executable_dir_; }
75 76
76 std::string& plugins_dir() { return plugins_dir_; } 77 std::string& plugins_dir() { return plugins_dir_; }
77 const std::string& plugins_dir() const { return plugins_dir_; } 78 const std::string& plugins_dir() const { return plugins_dir_; }
78 79
80 UniqueVector<const Target*>& deps() { return deps_; }
brettw 2016/03/21 22:49:47 Can you call this "bundle_deps" and comment that t
sdefresne 2016/03/22 12:34:05 done.
81 const UniqueVector<const Target*>& deps() const { return deps_; }
82
79 private: 83 private:
80 std::vector<SourceFile> asset_catalog_sources_; 84 std::vector<SourceFile> asset_catalog_sources_;
81 std::vector<BundleFileRule> file_rules_; 85 std::vector<BundleFileRule> file_rules_;
86 UniqueVector<const Target*> deps_;
82 87
83 // All those values are subdirectories relative to root_build_dir, and apart 88 // All those values are subdirectories relative to root_build_dir, and apart
84 // from root_dir, they are either equal to root_dir_ or subdirectories of it. 89 // from root_dir, they are either equal to root_dir_ or subdirectories of it.
85 std::string root_dir_; 90 std::string root_dir_;
86 std::string resources_dir_; 91 std::string resources_dir_;
87 std::string executable_dir_; 92 std::string executable_dir_;
88 std::string plugins_dir_; 93 std::string plugins_dir_;
89 }; 94 };
90 95
91 #endif // TOOLS_GN_BUNDLE_DATA_H_ 96 #endif // TOOLS_GN_BUNDLE_DATA_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | tools/gn/target.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698