Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: test/cctest/test-asm-validator.cc

Issue 1804243003: Fix conversion to float32, typing issue, split apart asm-wasm tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/asm-wasm-builder.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-asm-validator.cc
diff --git a/test/cctest/test-asm-validator.cc b/test/cctest/test-asm-validator.cc
index d2a70d438ab578e270390f47b79f14e1e0c9ffdf..92ac6bdf1fb0ab094f32a92878f6b1405bedad42 100644
--- a/test/cctest/test-asm-validator.cc
+++ b/test/cctest/test-asm-validator.cc
@@ -1153,7 +1153,7 @@ TEST(TernaryMismatchIntish) {
TEST(TernaryMismatchInt32Float32) {
CHECK_FUNC_ERROR(
- "function bar() { var x = 1; var y = 2; return (x?fround(y):x)|0; }\n"
+ "function bar() { var x = 1; var y = 2.0; return (x?fround(y):x)|0; }\n"
"function foo() { bar(); }",
"asm: line 1: then and else expressions in ? must have the same type\n");
}
@@ -1173,9 +1173,16 @@ TEST(BadIntishMultiply) {
"asm: line 1: intish not allowed in multiply\n");
}
-TEST(FroundFloat32) {
- CHECK_FUNC_TYPES_BEGIN(
+TEST(IntToFloat32) {
+ CHECK_FUNC_ERROR(
"function bar() { var x = 1; return fround(x); }\n"
+ "function foo() { bar(); }",
+ "asm: line 1: illegal function argument type\n");
+}
+
+TEST(Int32ToFloat32) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 1; return fround(x|0); }\n"
"function foo() { bar(); }") {
CHECK_EXPR(FunctionLiteral, FUNC_F_TYPE) {
CHECK_EXPR(Assignment, Bounds(cache.kAsmInt)) {
@@ -1184,7 +1191,32 @@ TEST(FroundFloat32) {
}
CHECK_EXPR(Call, Bounds(cache.kAsmFloat)) {
CHECK_VAR(fround, FUNC_N2F_TYPE);
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kAsmSigned)) {
+ CHECK_VAR(x, Bounds(cache.kAsmInt));
+ CHECK_EXPR(Literal, Bounds(cache.kAsmFixnum));
+ }
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
+
+TEST(Uint32ToFloat32) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 1; return fround(x>>>0); }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_F_TYPE) {
+ CHECK_EXPR(Assignment, Bounds(cache.kAsmInt)) {
CHECK_VAR(x, Bounds(cache.kAsmInt));
+ CHECK_EXPR(Literal, Bounds(cache.kAsmFixnum));
+ }
+ CHECK_EXPR(Call, Bounds(cache.kAsmFloat)) {
+ CHECK_VAR(fround, FUNC_N2F_TYPE);
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kAsmUnsigned)) {
+ CHECK_VAR(x, Bounds(cache.kAsmInt));
+ CHECK_EXPR(Literal, Bounds(cache.kAsmFixnum));
+ }
}
}
CHECK_SKIP();
@@ -1192,6 +1224,55 @@ TEST(FroundFloat32) {
CHECK_FUNC_TYPES_END
}
+TEST(Float64ToFloat32) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 1.0; return fround(x); }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_F_TYPE) {
+ CHECK_EXPR(Assignment, Bounds(cache.kAsmDouble)) {
+ CHECK_VAR(x, Bounds(cache.kAsmDouble));
+ CHECK_EXPR(Literal, Bounds(cache.kAsmDouble));
+ }
+ CHECK_EXPR(Call, Bounds(cache.kAsmFloat)) {
+ CHECK_VAR(fround, FUNC_N2F_TYPE);
+ CHECK_VAR(x, Bounds(cache.kAsmDouble));
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
+
+TEST(Int32ToFloat32ToInt32) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 1; return ~~fround(x|0) | 0; }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) {
+ CHECK_EXPR(Assignment, Bounds(cache.kAsmInt)) {
+ CHECK_VAR(x, Bounds(cache.kAsmInt));
+ CHECK_EXPR(Literal, Bounds(cache.kAsmFixnum));
+ }
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kAsmSigned)) {
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kAsmSigned)) {
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kAsmSigned)) {
+ CHECK_EXPR(Call, Bounds(cache.kAsmFloat)) {
+ CHECK_VAR(fround, FUNC_N2F_TYPE);
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kAsmSigned)) {
+ CHECK_VAR(x, Bounds(cache.kAsmInt));
+ CHECK_EXPR(Literal, Bounds(cache.kAsmFixnum));
+ }
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kAsmSigned));
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kAsmSigned));
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kAsmFixnum));
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
TEST(Addition4) {
CHECK_FUNC_TYPES_BEGIN(
@@ -1276,7 +1357,7 @@ TEST(CompareMismatchInt32Uint32) {
TEST(CompareMismatchInt32Float32) {
CHECK_FUNC_ERROR(
- "function bar() { var x = 1; var y = 2; return (x < fround(y))|0; }\n"
+ "function bar() { var x = 1; var y = 2.0; return (x < fround(y))|0; }\n"
"function foo() { bar(); }",
"asm: line 1: left and right side of comparison must match\n");
}
@@ -1754,6 +1835,12 @@ TEST(LogicalOrOperator) {
"asm: line 1: illegal logical operator\n");
}
+TEST(BitOrDouble) {
+ CHECK_FUNC_ERROR(
+ "function bar() { var x = 1.0; return x | 0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 1: intish required\n");
+}
TEST(BadLiteral) {
CHECK_FUNC_ERROR(
« no previous file with comments | « src/wasm/asm-wasm-builder.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698