Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1804143005: Reverts a temporary fix for UIPasteboard on iOS 9 beta 5. (Closed)

Created:
4 years, 9 months ago by stkhapugin
Modified:
4 years, 9 months ago
Reviewers:
jif, Olivier, olivierrobin
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reverts a temporary fix for UIPasteboard on iOS 9 beta 5. Reverted CL: https://codereview.chromium.org/1293693006. In iOS 9 (release) and later, the pasteboard bug was fixed. BUG=588715 Committed: https://crrev.com/4b14237f3ebf1e8117b94626b548a336da6aa601 Cr-Commit-Position: refs/heads/master@{#381706}

Patch Set 1 #

Patch Set 2 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M components/open_from_clipboard/clipboard_recent_content_ios.mm View 4 chunks +8 lines, -10 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
stkhapugin
PTAL
4 years, 9 months ago (2016-03-16 17:45:30 UTC) #3
Olivier
lgtm
4 years, 9 months ago (2016-03-16 17:47:33 UTC) #5
jif
On 2016/03/16 17:47:33, Olivier Robin wrote: > lgtm lgtm Are you planning on writing a ...
4 years, 9 months ago (2016-03-16 17:50:33 UTC) #6
stkhapugin
PTAL - added a unit test for the bug we had
4 years, 9 months ago (2016-03-17 13:30:03 UTC) #7
jif
lgtm
4 years, 9 months ago (2016-03-17 14:15:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804143005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804143005/20001
4 years, 9 months ago (2016-03-17 14:15:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 14:44:07 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 14:45:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b14237f3ebf1e8117b94626b548a336da6aa601
Cr-Commit-Position: refs/heads/master@{#381706}

Powered by Google App Engine
This is Rietveld 408576698