Open from clipboard: Support nil clipboard

Open from clipboard: Support nil clipboard

Starting with iOS9 beta 5, the clipboard string can be nil in some
circonstances.
Consider this as a temporary access error and not a pasteboard change.

Committed: https://crrev.com/4f12d389f9b35a11a8ab36aedc2368b91735c32d
Cr-Commit-Position: refs/heads/master@{#343648}

[Olivier, 2015-08-14 13:46:05]

olivierrobin@chromium.org changed reviewers:
+ droger@chromium.org, jif@chromium.org

[jif, 2015-08-14 14:23:32]

lgtm

[droger, 2015-08-17 08:27:40]

https://codereview.chromium.org/1293693006/diff/20001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.mm (right):

https://codereview.chromium.org/1293693006/diff/20001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:234: const
std::string clipboard = base::SysNSStringToUTF8(clipboard_string);
It seems this change does not affect the behavior of the function. Is it a
mistake?

[Olivier, 2015-08-17 08:33:19]

https://codereview.chromium.org/1293693006/diff/20001/components/open_from_cl...
File components/open_from_clipboard/clipboard_recent_content_ios.mm (right):

https://codereview.chromium.org/1293693006/diff/20001/components/open_from_cl...
components/open_from_clipboard/clipboard_recent_content_ios.mm:234: const
std::string clipboard = base::SysNSStringToUTF8(clipboard_string);
On 2015/08/17 08:27:39, droger wrote:
> It seems this change does not affect the behavior of the function. Is it a
> mistake?

The result is the same.
But adding the early return avoid testing the schemes and 
If [[UIPasteboard generalPasteboard] string] is nil, we should do at little as
possible, and specially not update the stored entries in NSUserDefaults.
Adding an early return will also avoid mistakes if something is added to the
function.

[droger, 2015-08-17 08:36:41]

Ok, thanks for the explanation. LGTM.

[Olivier, 2015-08-17 08:50:26]

Thanks

[Olivier, 2015-08-17 08:50:29]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2015-08-17 08:50:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293693006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293693006/20001

[commit-bot: I haz the power, 2015-08-17 09:03:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-17 09:04:06]

Patchset 2 (id:??) landed as
https://crrev.com/4f12d389f9b35a11a8ab36aedc2368b91735c32d
Cr-Commit-Position: refs/heads/master@{#343648}