Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804133002: Subzero. Uses unique_ptrs in the emit queue. (Closed)

Created:
4 years, 9 months ago by John
Modified:
4 years, 9 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Uses unique_ptrs in the emit queue. Because explicit memory ownership is awesome! BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bd2e2315b9897593b2cf804241a5e3726ec209c4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addresses comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -53 lines) Patch
M src/IceCfg.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/IceGlobalContext.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/IceGlobalContext.cpp View 11 chunks +29 lines, -24 lines 0 comments Download
M src/IceThreading.h View 5 chunks +14 lines, -12 lines 0 comments Download
M src/IceThreading.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M src/IceTranslator.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/IceTranslator.cpp View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
John
4 years, 9 months ago (2016-03-15 17:39:51 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1804133002/diff/1/src/IceTranslator.h File src/IceTranslator.h (right): https://codereview.chromium.org/1804133002/diff/1/src/IceTranslator.h#newcode53 src/IceTranslator.h:53: /// Translates the constructed ICE function Fcn to ...
4 years, 9 months ago (2016-03-15 17:56:08 UTC) #3
John
https://codereview.chromium.org/1804133002/diff/1/src/IceTranslator.h File src/IceTranslator.h (right): https://codereview.chromium.org/1804133002/diff/1/src/IceTranslator.h#newcode53 src/IceTranslator.h:53: /// Translates the constructed ICE function Fcn to machine ...
4 years, 9 months ago (2016-03-15 17:57:58 UTC) #4
John
4 years, 9 months ago (2016-03-15 17:57:58 UTC) #5
John
4 years, 9 months ago (2016-03-15 18:06:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bd2e2315b9897593b2cf804241a5e3726ec209c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698