Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/IceThreading.cpp

Issue 1804133002: Subzero. Uses unique_ptrs in the emit queue. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceThreading.h ('k') | src/IceTranslator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceThreading.cpp - Threading function definitions ------===// 1 //===- subzero/src/IceThreading.cpp - Threading function definitions ------===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
11 /// \brief Defines threading-related functions. 11 /// \brief Defines threading-related functions.
12 /// 12 ///
13 //===----------------------------------------------------------------------===// 13 //===----------------------------------------------------------------------===//
14 14
15 #include "IceThreading.h" 15 #include "IceThreading.h"
16 16
17 #include "IceCfg.h" 17 #include "IceCfg.h"
18 #include "IceDefs.h" 18 #include "IceDefs.h"
19 19
20 namespace Ice { 20 namespace Ice {
21 21
22 EmitterWorkItem::EmitterWorkItem(uint32_t Seq) 22 EmitterWorkItem::EmitterWorkItem(uint32_t Seq)
23 : Sequence(Seq), Kind(WI_Nop), GlobalInits(nullptr), Function(nullptr), 23 : Sequence(Seq), Kind(WI_Nop), GlobalInits(nullptr), Function(nullptr),
24 RawFunc(nullptr) {} 24 RawFunc(nullptr) {}
25 EmitterWorkItem::EmitterWorkItem(uint32_t Seq, VariableDeclarationList *D) 25 EmitterWorkItem::EmitterWorkItem(uint32_t Seq,
26 : Sequence(Seq), Kind(WI_GlobalInits), GlobalInits(D), Function(nullptr), 26 std::unique_ptr<VariableDeclarationList> D)
27 : Sequence(Seq), Kind(WI_GlobalInits), GlobalInits(std::move(D)),
28 Function(nullptr), RawFunc(nullptr) {}
29 EmitterWorkItem::EmitterWorkItem(uint32_t Seq, std::unique_ptr<Assembler> A)
30 : Sequence(Seq), Kind(WI_Asm), GlobalInits(nullptr), Function(std::move(A)),
27 RawFunc(nullptr) {} 31 RawFunc(nullptr) {}
28 EmitterWorkItem::EmitterWorkItem(uint32_t Seq, Assembler *A) 32 EmitterWorkItem::EmitterWorkItem(uint32_t Seq, std::unique_ptr<Cfg> F)
29 : Sequence(Seq), Kind(WI_Asm), GlobalInits(nullptr), Function(A),
30 RawFunc(nullptr) {}
31 EmitterWorkItem::EmitterWorkItem(uint32_t Seq, Cfg *F)
32 : Sequence(Seq), Kind(WI_Cfg), GlobalInits(nullptr), Function(nullptr), 33 : Sequence(Seq), Kind(WI_Cfg), GlobalInits(nullptr), Function(nullptr),
33 RawFunc(F) {} 34 RawFunc(std::move(F)) {}
34 35
35 void EmitterWorkItem::setGlobalInits( 36 void EmitterWorkItem::setGlobalInits(
36 std::unique_ptr<VariableDeclarationList> GloblInits) { 37 std::unique_ptr<VariableDeclarationList> GloblInits) {
37 assert(getKind() == WI_Asm || getKind() == WI_Cfg); 38 assert(getKind() == WI_Asm || getKind() == WI_Cfg);
38 GlobalInits = std::move(GloblInits); 39 GlobalInits = std::move(GloblInits);
39 } 40 }
40 41
41 std::unique_ptr<VariableDeclarationList> EmitterWorkItem::getGlobalInits() { 42 std::unique_ptr<VariableDeclarationList> EmitterWorkItem::getGlobalInits() {
42 assert(getKind() == WI_GlobalInits || getKind() == WI_Asm || 43 assert(getKind() == WI_GlobalInits || getKind() == WI_Asm ||
43 getKind() == WI_Cfg); 44 getKind() == WI_Cfg);
44 return std::move(GlobalInits); 45 return std::move(GlobalInits);
45 } 46 }
46 47
47 std::unique_ptr<Assembler> EmitterWorkItem::getAsm() { 48 std::unique_ptr<Assembler> EmitterWorkItem::getAsm() {
48 assert(getKind() == WI_Asm); 49 assert(getKind() == WI_Asm);
49 return std::move(Function); 50 return std::move(Function);
50 } 51 }
51 52
52 std::unique_ptr<Cfg> EmitterWorkItem::getCfg() { 53 std::unique_ptr<Cfg> EmitterWorkItem::getCfg() {
53 assert(getKind() == WI_Cfg); 54 assert(getKind() == WI_Cfg);
54 return std::move(RawFunc); 55 return std::move(RawFunc);
55 } 56 }
56 57
57 } // end of namespace Ice 58 } // end of namespace Ice
OLDNEW
« no previous file with comments | « src/IceThreading.h ('k') | src/IceTranslator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698