Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5197)

Unified Diff: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

Issue 1804123003: [Extensions] Refactor extension action execution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/page_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
index c0e03118622bd24727e58f458a1cbce14ef957e3..dbb9671ed8369f131d7bf447b7332cbad4c959a6 100644
--- a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_action_icon_factory.h"
#include "chrome/browser/extensions/extension_action_manager.h"
+#include "chrome/browser/extensions/extension_action_runner.h"
#include "chrome/browser/extensions/extension_action_test_util.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -60,8 +61,9 @@ IN_PROC_BROWSER_TEST_F(PageActionApiTest, Basic) {
{
// Simulate the page action being clicked.
ResultCatcher catcher;
- ExtensionActionAPI::Get(browser()->profile())->ExecuteExtensionAction(
- extension, browser(), true);
+ ExtensionActionRunner::GetForWebContents(
+ browser()->tab_strip_model()->GetActiveWebContents())
+ ->RunAction(extension, true);
EXPECT_TRUE(catcher.GetNextResult());
}
@@ -103,8 +105,9 @@ IN_PROC_BROWSER_TEST_F(PageActionApiTest, AddPopup) {
// install a page action popup.
{
ResultCatcher catcher;
- ExtensionActionAPI::Get(browser()->profile())->ExecuteExtensionAction(
- extension, browser(), true);
+ ExtensionActionRunner::GetForWebContents(
+ browser()->tab_strip_model()->GetActiveWebContents())
+ ->RunAction(extension, true);
ASSERT_TRUE(catcher.GetNextResult());
}
@@ -229,8 +232,9 @@ IN_PROC_BROWSER_TEST_F(PageActionApiTest, TestTriggerPageAction) {
{
// Simulate the page action being clicked.
ResultCatcher catcher;
- ExtensionActionAPI::Get(browser()->profile())->ExecuteExtensionAction(
- extension, browser(), true);
+ ExtensionActionRunner::GetForWebContents(
+ browser()->tab_strip_model()->GetActiveWebContents())
+ ->RunAction(extension, true);
EXPECT_TRUE(catcher.GetNextResult());
}

Powered by Google App Engine
This is Rietveld 408576698