Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/cross_process_frame_connector.cc
diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc
index b5e415ced16124ab9c7b22272546a422fa03fedb..a066bc996de73254416dbe064500bf9ab639fbd6 100644
--- a/content/browser/frame_host/cross_process_frame_connector.cc
+++ b/content/browser/frame_host/cross_process_frame_connector.cc
@@ -199,6 +199,11 @@ void CrossProcessFrameConnector::OnForwardInputEvent(
void CrossProcessFrameConnector::OnFrameRectChanged(
const gfx::Rect& frame_rect) {
+ // TODO(wjmaclean) When changing the zoom of a WebView child without also
+ // changing the zoom of the embedder (e.g. using WebView.setZoom()), we
+ // shouldn't propagate this change in the frame rect. We need to find a way
+ // to detect when this happens.
+ // http://crbug.com/xxxxxx <- Don't land without filing this bug.
ncarter (slow) 2016/04/28 22:30:14 Don't forget this.
wjmaclean 2016/04/29 13:40:41 As promised earlier, once I've collected all the n
if (!frame_rect.size().IsEmpty())
SetRect(frame_rect);
}

Powered by Google App Engine
This is Rietveld 408576698