chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index ba5e2f7971283c071d0d8b35ad0530c78dc97631..f49e07638996371a832030996b4d66fb5edd3937 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -2438,7 +2438,13 @@ class WebViewCaptureTest : public WebViewTest {

INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewCaptureTest, testing::Bool());

IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestZoomAPI) {

- TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);

+ // TODO(wjmaclean): This test is broken, but only when the

+ // --use-cross-process-frames-for-guests flag is specified. This needs to be

+ // fixed. See also comment in

+ // CrossProcessFrameConnector::OnFrameRectChanged().

+ // http://crbug.com/xxxxxx <-- Don't land without filing this bug.

Lei Zhang 2016/04/29 18:03:55 Time to file a bug since you are starting to get L

+ if (!GetParam())

+ TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);

}

IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFindAPI) {

« no previous file with comments | « no previous file | chrome/browser/renderer_preferences_util.cc » ('j') | content/browser/frame_host/cross_process_frame_connector.cc » ('J')