Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, exclude part of test since not supported on Android. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 1e1c090e3ff143035e8ed80aec9df450d771cb2d..91b7682d9fd821adfa4c20e4a4e747149465ac9f 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -1065,8 +1065,8 @@ TEST_F(RenderFrameHostManagerTest, WebUIInNewTab) {
RenderFrameHostManager* manager1 =
web_contents1->GetRenderManagerForTesting();
// Test the case that new RVH is considered live.
- manager1->current_host()->CreateRenderView(-1, MSG_ROUTING_NONE, -1,
- FrameReplicationState(), false);
+ manager1->current_host()->CreateRenderView(
+ -1, MSG_ROUTING_NONE, -1, FrameReplicationState(), false);
alexmos 2016/04/27 23:39:51 nit: no change here other than wrapping, here and
wjmaclean 2016/04/28 13:20:11 Indeed. I don't even remember at what stage this f
EXPECT_TRUE(manager1->current_host()->IsRenderViewLive());
EXPECT_TRUE(manager1->current_frame_host()->IsRenderFrameLive());
@@ -1099,8 +1099,8 @@ TEST_F(RenderFrameHostManagerTest, WebUIInNewTab) {
web_contents2->GetRenderManagerForTesting();
// Make sure the new RVH is considered live. This is usually done in
// RenderWidgetHost::Init when opening a new tab from a link.
- manager2->current_host()->CreateRenderView(-1, MSG_ROUTING_NONE, -1,
- FrameReplicationState(), false);
+ manager2->current_host()->CreateRenderView(
+ -1, MSG_ROUTING_NONE, -1, FrameReplicationState(), false);
EXPECT_TRUE(manager2->current_host()->IsRenderViewLive());
const GURL kUrl2("chrome://foo/bar");

Powered by Google App Engine
This is Rietveld 408576698