Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, exclude part of test since not supported on Android. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index ba5e2f7971283c071d0d8b35ad0530c78dc97631..f49e07638996371a832030996b4d66fb5edd3937 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -2438,7 +2438,13 @@ class WebViewCaptureTest : public WebViewTest {
INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewCaptureTest, testing::Bool());
IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestZoomAPI) {
- TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);
+ // TODO(wjmaclean): This test is broken, but only when the
+ // --use-cross-process-frames-for-guests flag is specified. This needs to be
+ // fixed. See also comment in
+ // CrossProcessFrameConnector::OnFrameRectChanged().
+ // http://crbug.com/xxxxxx <-- Don't land without filing this bug.
alexmos 2016/04/27 23:39:51 Bug numbers still needed here. :) (Also the one i
wjmaclean 2016/04/28 13:20:11 I generally put these in just before landing, as I
+ if (!GetParam())
+ TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);
}
IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFindAPI) {

Powered by Google App Engine
This is Rietveld 408576698