Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: content/common/view_messages.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert to use PageMsg instead of FrameMsg. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 2818439ab22a8980e4606b5a33914c7cb16baed1..48e88927d5f7daadbb726bbdb0c29bca2df659c3 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -257,7 +257,6 @@ IPC_STRUCT_TRAITS_BEGIN(content::RendererPreferences)
IPC_STRUCT_TRAITS_MEMBER(enable_referrers)
IPC_STRUCT_TRAITS_MEMBER(enable_do_not_track)
IPC_STRUCT_TRAITS_MEMBER(webrtc_ip_handling_policy)
- IPC_STRUCT_TRAITS_MEMBER(default_zoom_level)
IPC_STRUCT_TRAITS_MEMBER(user_agent_override)
IPC_STRUCT_TRAITS_MEMBER(accept_languages)
IPC_STRUCT_TRAITS_MEMBER(report_frame_name_changes)
@@ -537,6 +536,9 @@ IPC_STRUCT_BEGIN(ViewMsg_New_Params)
// The maximum size to layout the page if auto-resize is enabled.
IPC_STRUCT_MEMBER(gfx::Size, max_size)
+
+ // The preferred zoom level for sub-frames
alexmos 2016/04/07 23:48:08 nit: s/sub-frames/subframes./ (just for consisten
alexmos 2016/04/07 23:48:08 Not sure what you mean by the zoom level being "pr
wjmaclean 2016/04/08 20:13:29 Done.
wjmaclean 2016/04/08 20:13:29 You're right, we probably don't need "preferred",
alexmos 2016/04/11 23:19:10 OK. The comment still has "preferred" in it, so m
wjmaclean 2016/04/13 18:47:47 Done.
+ IPC_STRUCT_MEMBER(double, preferred_subframe_zoom_level)
IPC_STRUCT_END()
#if defined(OS_MACOSX)
@@ -691,19 +693,6 @@ IPC_MESSAGE_ROUTED2(ViewMsg_SetZoomLevelForLoadingURL,
GURL /* url */,
double /* zoom_level */)
-// Set the zoom level for a particular url, so all render views
-// displaying this url can update their zoom levels to match.
-// If scheme is empty, then only host is used for matching.
-IPC_MESSAGE_CONTROL3(ViewMsg_SetZoomLevelForCurrentURL,
- std::string /* scheme */,
- std::string /* host */,
- double /* zoom_level */)
-
-// Set the zoom level for a particular render view.
-IPC_MESSAGE_ROUTED2(ViewMsg_SetZoomLevelForView,
- bool /* uses_temporary_zoom_level */,
- double /* zoom_level */)
-
// Change encoding of page in the renderer.
IPC_MESSAGE_ROUTED1(ViewMsg_SetPageEncoding,
std::string /*new encoding name*/)

Powered by Google App Engine
This is Rietveld 408576698