Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: content/common/page_messages.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert to use PageMsg instead of FrameMsg. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/page_messages.h
diff --git a/content/common/page_messages.h b/content/common/page_messages.h
index 284c134508b5d9227303ec5f96ec52235e628176..668b3f7ccd23d100f39a9d6053ad8f1f7f8dbbc0 100644
--- a/content/common/page_messages.h
+++ b/content/common/page_messages.h
@@ -2,8 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#ifndef CONTENT_COMMON_PAGE_MESSAGES_H_
+#define CONTENT_COMMON_PAGE_MESSAGES_H_
+
#include "ipc/ipc_message_macros.h"
alexmos 2016/04/07 23:48:08 nit: why this blank line?
wjmaclean 2016/04/08 20:13:29 Done.
+#include "ui/gfx/geometry/rect.h"
+
// IPC messages for page-level actions.
// Multiply-included message file, hence no include guard.
@@ -12,14 +17,28 @@
#define IPC_MESSAGE_START PageMsgStart
+// Create a 'type' for our enum, since IPC doesn't support enum classes (yet).
alexmos 2016/04/07 23:48:08 Hmm, we use things like WebSandboxFlags and WebTre
wjmaclean 2016/04/08 20:13:29 Ahh, ok. I was getting messages about the pickler
+using PageMsg_SetZoomLevel_Command = int;
+enum {
+ ZOOM_SET_TEMPORARY,
+ ZOOM_CLEAR_TEMPORARY,
+ ZOOM_USE_CURRENT_TEMPORARY_MODE
+};
+
// Messages sent from the browser to the renderer.
IPC_MESSAGE_ROUTED1(PageMsg_UpdateWindowScreenRect,
gfx::Rect /* window_screen_rect */)
+IPC_MESSAGE_ROUTED2(PageMsg_SetZoomLevel,
+ PageMsg_SetZoomLevel_Command /* command */,
+ double /* zoom_level */)
+
// -----------------------------------------------------------------------------
// Messages sent from the renderer to the browser.
// Adding a new message? Stick to the sort order above: first platform
// independent PageMsg, then ifdefs for platform specific PageMsg, then platform
// independent PageHostMsg, then ifdefs for platform specific PageHostMsg.
+
+#endif // CONTENT_COMMON_PAGE_MESSAGES_H_

Powered by Google App Engine
This is Rietveld 408576698