third_party/WebKit/Source/web/WebViewImpl.h - Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address alexmos@ comments, run two experiments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | third_party/WebKit/public/web/WebView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index a428bd4d4f0944c636d32bb8f4f0e7e1e809523b..91b2a05a3a391cbba2325e01ab69acb78cd942f4 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -546,6 +546,7 @@ private:

void performResize();

void resizeViewWhileAnchored(FrameView*);

+ double setZoomLevelForFrame(WebLocalFrame*, double zoomLevel) override;

friend class WebView; // So WebView::Create can call our constructor

friend class WTF::RefCounted<WebViewImpl>;

@@ -623,6 +624,7 @@ private:

void cancelPagePopup();

void updatePageOverlays();

+ double setZoomLevelForFrame(LocalFrame*, double zoomLevel);

float deviceScaleFactor() const;

WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)