Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address alexmos@ comments, run two experiments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 539
540 void scrollAndRescaleViewports(float scaleFactor, const IntPoint& mainFrameO rigin, const FloatPoint& visualViewportOrigin); 540 void scrollAndRescaleViewports(float scaleFactor, const IntPoint& mainFrameO rigin, const FloatPoint& visualViewportOrigin);
541 541
542 float maximumLegiblePageScale() const; 542 float maximumLegiblePageScale() const;
543 void refreshPageScaleFactorAfterLayout(); 543 void refreshPageScaleFactorAfterLayout();
544 void resumeTreeViewCommitsIfRenderingReady(); 544 void resumeTreeViewCommitsIfRenderingReady();
545 IntSize contentsSize() const; 545 IntSize contentsSize() const;
546 546
547 void performResize(); 547 void performResize();
548 void resizeViewWhileAnchored(FrameView*); 548 void resizeViewWhileAnchored(FrameView*);
549 double setZoomLevelForFrame(WebLocalFrame*, double zoomLevel) override;
549 550
550 friend class WebView; // So WebView::Create can call our constructor 551 friend class WebView; // So WebView::Create can call our constructor
551 friend class WTF::RefCounted<WebViewImpl>; 552 friend class WTF::RefCounted<WebViewImpl>;
552 friend void setCurrentInputEventForTest(const WebInputEvent*); 553 friend void setCurrentInputEventForTest(const WebInputEvent*);
553 554
554 enum DragAction { 555 enum DragAction {
555 DragEnter, 556 DragEnter,
556 DragOver 557 DragOver
557 }; 558 };
558 559
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
616 WebPlugin* focusedPluginIfInputMethodSupported(LocalFrame*); 617 WebPlugin* focusedPluginIfInputMethodSupported(LocalFrame*);
617 618
618 WebGestureEvent createGestureScrollEventFromFling(WebInputEvent::Type, WebGe stureDevice) const; 619 WebGestureEvent createGestureScrollEventFromFling(WebInputEvent::Type, WebGe stureDevice) const;
619 620
620 void enablePopupMouseWheelEventListener(); 621 void enablePopupMouseWheelEventListener();
621 void disablePopupMouseWheelEventListener(); 622 void disablePopupMouseWheelEventListener();
622 623
623 void cancelPagePopup(); 624 void cancelPagePopup();
624 void updatePageOverlays(); 625 void updatePageOverlays();
625 626
627 double setZoomLevelForFrame(LocalFrame*, double zoomLevel);
626 float deviceScaleFactor() const; 628 float deviceScaleFactor() const;
627 629
628 WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.) 630 WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
629 WebSpellCheckClient* m_spellCheckClient; 631 WebSpellCheckClient* m_spellCheckClient;
630 632
631 Persistent<ChromeClientImpl> m_chromeClientImpl; 633 Persistent<ChromeClientImpl> m_chromeClientImpl;
632 ContextMenuClientImpl m_contextMenuClientImpl; 634 ContextMenuClientImpl m_contextMenuClientImpl;
633 DragClientImpl m_dragClientImpl; 635 DragClientImpl m_dragClientImpl;
634 EditorClientImpl m_editorClientImpl; 636 EditorClientImpl m_editorClientImpl;
635 SpellCheckerClientImpl m_spellCheckerClientImpl; 637 SpellCheckerClientImpl m_spellCheckerClientImpl;
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 }; 773 };
772 774
773 DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.is WebView()); 775 DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.is WebView());
774 // We have no ways to check if the specified WebView is an instance of 776 // We have no ways to check if the specified WebView is an instance of
775 // WebViewImpl because WebViewImpl is the only implementation of WebView. 777 // WebViewImpl because WebViewImpl is the only implementation of WebView.
776 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 778 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
777 779
778 } // namespace blink 780 } // namespace blink
779 781
780 #endif 782 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698