Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address alexmos@ comments, run two experiments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 77f73eab30e09edb9196b3b5000b5d75966a7f28..b24c8ea5f4856be24d9c27ed3b9542617416793a 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -224,6 +224,18 @@ class CONTENT_EXPORT WebContentsImpl
const ui::AXTreeUpdate&)>;
void RequestAXTreeSnapshot(AXTreeSnapshotCallback callback);
+ // Set a temporary zoom level for the frames associated with this WebContents.
+ // If |is_temporary| is true, we are setting a new temporary zoom level,
+ // otherwise we are clearing a previously set temporary zoom level.
+ void SetTemporaryZoomLevel(double level, bool is_temporary);
+ // Sets the zoom level for frames associated with this WebContents.
alexmos 2016/04/07 01:20:56 nit: blank line above comment might be a bit more
wjmaclean 2016/04/07 12:55:36 Done.
+ void UpdateZoom(double level);
+ // Sets the zoom level for frames associated with this WebContents if it
+ // matches |host| and (if non-empty) |scheme|.
alexmos 2016/04/07 01:20:56 nit: clarify what it means to match |host| and |sc
wjmaclean 2016/04/07 12:55:36 Done.
+ void UpdateZoomIfNecessary(const std::string& scheme,
+ const std::string& host,
+ double level);
+
// WebContents ------------------------------------------------------
WebContentsDelegate* GetDelegate() override;
void SetDelegate(WebContentsDelegate* delegate) override;

Powered by Google App Engine
This is Rietveld 408576698