Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address alexmos@ comments, run two experiments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 // have been removed. 217 // have been removed.
218 void RemoveAccessibilityMode(AccessibilityMode mode); 218 void RemoveAccessibilityMode(AccessibilityMode mode);
219 219
220 // Request a one-time snapshot of the accessibility tree without changing 220 // Request a one-time snapshot of the accessibility tree without changing
221 // the accessibility mode. 221 // the accessibility mode.
222 using AXTreeSnapshotCallback = 222 using AXTreeSnapshotCallback =
223 base::Callback<void( 223 base::Callback<void(
224 const ui::AXTreeUpdate&)>; 224 const ui::AXTreeUpdate&)>;
225 void RequestAXTreeSnapshot(AXTreeSnapshotCallback callback); 225 void RequestAXTreeSnapshot(AXTreeSnapshotCallback callback);
226 226
227 // Set a temporary zoom level for the frames associated with this WebContents.
228 // If |is_temporary| is true, we are setting a new temporary zoom level,
229 // otherwise we are clearing a previously set temporary zoom level.
230 void SetTemporaryZoomLevel(double level, bool is_temporary);
231 // Sets the zoom level for frames associated with this WebContents.
alexmos 2016/04/07 01:20:56 nit: blank line above comment might be a bit more
wjmaclean 2016/04/07 12:55:36 Done.
232 void UpdateZoom(double level);
233 // Sets the zoom level for frames associated with this WebContents if it
234 // matches |host| and (if non-empty) |scheme|.
alexmos 2016/04/07 01:20:56 nit: clarify what it means to match |host| and |sc
wjmaclean 2016/04/07 12:55:36 Done.
235 void UpdateZoomIfNecessary(const std::string& scheme,
236 const std::string& host,
237 double level);
238
227 // WebContents ------------------------------------------------------ 239 // WebContents ------------------------------------------------------
228 WebContentsDelegate* GetDelegate() override; 240 WebContentsDelegate* GetDelegate() override;
229 void SetDelegate(WebContentsDelegate* delegate) override; 241 void SetDelegate(WebContentsDelegate* delegate) override;
230 NavigationControllerImpl& GetController() override; 242 NavigationControllerImpl& GetController() override;
231 const NavigationControllerImpl& GetController() const override; 243 const NavigationControllerImpl& GetController() const override;
232 BrowserContext* GetBrowserContext() const override; 244 BrowserContext* GetBrowserContext() const override;
233 const GURL& GetURL() const override; 245 const GURL& GetURL() const override;
234 const GURL& GetVisibleURL() const override; 246 const GURL& GetVisibleURL() const override;
235 const GURL& GetLastCommittedURL() const override; 247 const GURL& GetLastCommittedURL() const override;
236 RenderProcessHost* GetRenderProcessHost() const override; 248 RenderProcessHost* GetRenderProcessHost() const override;
(...skipping 1106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1343 // Adds/removes a callback called on creation of each new WebContents. 1355 // Adds/removes a callback called on creation of each new WebContents.
1344 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1356 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1345 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1357 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1346 1358
1347 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1359 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1348 }; 1360 };
1349 1361
1350 } // namespace content 1362 } // namespace content
1351 1363
1352 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1364 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698