Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: net/quic/quic_framer.h

Issue 180383004: Create QUIC_VERSION_16 which breaks the sent_info field out of the ACK (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Send STOP_WAITING_FRAME for QUIC version 16 and above with Ack Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_framer.h
diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h
index 228353384724831ca7eee33bffdc7548bf6f076c..67046023ce9ab7fa3c6cae92e2c3c2fe48105d8f 100644
--- a/net/quic/quic_framer.h
+++ b/net/quic/quic_framer.h
@@ -113,6 +113,9 @@ class NET_EXPORT_PRIVATE QuicFramerVisitorInterface {
virtual bool OnCongestionFeedbackFrame(
const QuicCongestionFeedbackFrame& frame) = 0;
+ // Called when a StopWaitingFrame has been parsed.
+ virtual bool OnStopWaitingFrame(const QuicStopWaitingFrame& frame) = 0;
+
// Called when a RstStreamFrame has been parsed.
virtual bool OnRstStreamFrame(const QuicRstStreamFrame& frame) = 0;
@@ -248,6 +251,9 @@ class NET_EXPORT_PRIVATE QuicFramer {
QuicVersion version,
QuicSequenceNumberLength sequence_number_length,
QuicSequenceNumberLength largest_observed_length);
+ // Size in bytes of a stop waiting frame.
+ static size_t GetStopWaitingFrameSize(
+ QuicSequenceNumberLength sequence_number_length);
// Size in bytes of all reset stream frame without the error details.
static size_t GetMinRstStreamFrameSize(QuicVersion quic_version);
// Size in bytes of all connection close frame fields without the error
@@ -401,8 +407,8 @@ class NET_EXPORT_PRIVATE QuicFramer {
uint8 frame_type,
QuicAckFrame* frame);
bool ProcessReceivedInfo(uint8 frame_type, ReceivedPacketInfo* received_info);
- bool ProcessSentInfo(const QuicPacketHeader& public_header,
- SentPacketInfo* sent_info);
+ bool ProcessStopWaitingFrame(const QuicPacketHeader& public_header,
+ QuicStopWaitingFrame* stop_waiting);
bool ProcessQuicCongestionFeedbackFrame(
QuicCongestionFeedbackFrame* congestion_feedback);
bool ProcessRstStreamFrame(QuicRstStreamFrame* frame);
@@ -452,9 +458,11 @@ class NET_EXPORT_PRIVATE QuicFramer {
bool AppendAckFrameAndTypeByte(const QuicPacketHeader& header,
const QuicAckFrame& frame,
QuicDataWriter* builder);
- bool AppendQuicCongestionFeedbackFrame(
- const QuicCongestionFeedbackFrame& frame,
- QuicDataWriter* builder);
+ bool AppendCongestionFeedbackFrame(const QuicCongestionFeedbackFrame& frame,
+ QuicDataWriter* builder);
+ bool AppendStopWaitingFrame(const QuicPacketHeader& header,
+ const QuicStopWaitingFrame& frame,
+ QuicDataWriter* builder);
bool AppendRstStreamFrame(const QuicRstStreamFrame& frame,
QuicDataWriter* builder);
bool AppendConnectionCloseFrame(const QuicConnectionCloseFrame& frame,

Powered by Google App Engine
This is Rietveld 408576698