Chromium Code Reviews| Index: net/quic/quic_connection_logger.cc |
| diff --git a/net/quic/quic_connection_logger.cc b/net/quic/quic_connection_logger.cc |
| index d52debe1faef89f99e2e39c4edfae149fc47a183..f2efdd208b7534df074b60f24fc49a66e532321b 100644 |
| --- a/net/quic/quic_connection_logger.cc |
| +++ b/net/quic/quic_connection_logger.cc |
| @@ -163,6 +163,17 @@ base::Value* NetLogQuicConnectionCloseFrameCallback( |
| return dict; |
| } |
| +base::Value* NetLogQuicStopWaitingFrameCallback( |
| + const QuicStopWaitingFrame* frame, |
| + NetLog::LogLevel /* log_level */) { |
| + base::DictionaryValue* dict = new base::DictionaryValue(); |
| + base::DictionaryValue* sent_info = new base::DictionaryValue(); |
| + dict->Set("sent_info", sent_info); |
| + sent_info->SetString("least_unacked", |
| + base::Uint64ToString(frame->least_unacked)); |
| + return dict; |
| +} |
| + |
| base::Value* NetLogQuicVersionNegotiationPacketCallback( |
| const QuicVersionNegotiationPacket* packet, |
| NetLog::LogLevel /* log_level */) { |
| @@ -271,6 +282,18 @@ void QuicConnectionLogger::OnFrameAddedToPacket(const QuicFrame& frame) { |
| break; |
| case GOAWAY_FRAME: |
| break; |
| + case WINDOW_UPDATE_FRAME: |
| + // TODO(rtenneti): Implement logging of WINDOW_UPDATE_FRAME. |
| + break; |
|
Ryan Hamilton
2014/02/26 00:25:20
Up to you, but I'd consider implementing these now
ramant (doing other things)
2014/02/26 00:50:49
Done.
|
| + case BLOCKED_FRAME: |
| + // TODO(rtenneti): Implement logging of BLOCKED_FRAME. |
| + break; |
| + case STOP_WAITING_FRAME: |
| + net_log_.AddEvent( |
| + NetLog::TYPE_QUIC_SESSION_STOP_WAITING_FRAME_SENT, |
| + base::Bind(&NetLogQuicStopWaitingFrameCallback, |
| + frame.stop_waiting_frame)); |
| + break; |
| default: |
| DCHECK(false) << "Illegal frame type: " << frame.type; |
| } |
| @@ -392,6 +415,13 @@ void QuicConnectionLogger::OnCongestionFeedbackFrame( |
| base::Bind(&NetLogQuicCongestionFeedbackFrameCallback, &frame)); |
| } |
| +void QuicConnectionLogger::OnStopWaitingFrame( |
| + const QuicStopWaitingFrame& frame) { |
| + net_log_.AddEvent( |
| + NetLog::TYPE_QUIC_SESSION_STOP_WAITING_FRAME_RECEIVED, |
| + base::Bind(&NetLogQuicStopWaitingFrameCallback, &frame)); |
| +} |
| + |
| void QuicConnectionLogger::OnRstStreamFrame(const QuicRstStreamFrame& frame) { |
| UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.RstStreamErrorCodeServer", |
| frame.error_code); |