Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 180383004: Create QUIC_VERSION_16 which breaks the sent_info field out of the ACK (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Create QUIC_VERSION_16 which breaks the sent_info field out of the ACK frame into a new STOP_WAITING frame. Does not change when this information is sent. That will happen in a follow-up CL. Merge internal change: 61838258

Patch Set 1 #

Patch Set 2 : Send STOP_WAITING_FRAME for QUIC version 16 and above with Ack #

Total comments: 2

Patch Set 3 : Added logging for WINDOW_UPDATE and BLOCKED frames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1409 lines, -309 lines) Patch
M net/base/net_log_event_type_list.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 7 chunks +16 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 15 chunks +83 lines, -29 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 2 3 chunks +53 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 131 chunks +356 lines, -171 lines 0 comments Download
M net/quic/quic_framer.h View 4 chunks +13 lines, -5 lines 0 comments Download
M net/quic/quic_framer.cc View 11 chunks +86 lines, -31 lines 0 comments Download
M net/quic/quic_framer_test.cc View 17 chunks +590 lines, -27 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M net/quic/quic_packet_generator.h View 3 chunks +11 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator.cc View 5 chunks +27 lines, -7 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 13 chunks +23 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.h View 9 chunks +16 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.cc View 7 chunks +18 lines, -3 lines 0 comments Download
M net/quic/quic_received_packet_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 5 chunks +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 5 chunks +17 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Thanks very much Ryan with your help porting this CL to chrome. All unit tests ...
6 years, 10 months ago (2014-02-26 00:20:34 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/180383004/diff/20001/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/180383004/diff/20001/net/quic/quic_connection_logger.cc#newcode287 net/quic/quic_connection_logger.cc:287: break; Up to you, but I'd consider implementing ...
6 years, 10 months ago (2014-02-26 00:25:19 UTC) #2
ramant (doing other things)
PTAL. Thanks much. https://codereview.chromium.org/180383004/diff/20001/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/180383004/diff/20001/net/quic/quic_connection_logger.cc#newcode287 net/quic/quic_connection_logger.cc:287: break; On 2014/02/26 00:25:20, Ryan Hamilton ...
6 years, 10 months ago (2014-02-26 00:50:49 UTC) #3
Ryan Hamilton
6 years, 10 months ago (2014-02-26 00:57:54 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698