net/quic/quic_packet_creator.cc - Issue 180383004: Create QUIC_VERSION_16 which breaks the sent_info field out of the ACK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_packet_creator.cc

Issue 180383004: Create QUIC_VERSION_16 which breaks the sent_info field out of the ACK (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added logging for WINDOW_UPDATE and BLOCKED frames Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_packet_creator.cc

diff --git a/net/quic/quic_packet_creator.cc b/net/quic/quic_packet_creator.cc

index b39965029134ee14cf06f586c55a8a8bc675c91b..f0e5c2bbc28b019eab5e62e24a13df322edddc1f 100644

--- a/net/quic/quic_packet_creator.cc

+++ b/net/quic/quic_packet_creator.cc

@@ -406,8 +406,15 @@ void QuicPacketCreator::FillPacketHeader(QuicFecGroupNumber fec_group,

}

bool QuicPacketCreator::ShouldRetransmit(const QuicFrame& frame) {

- return frame.type != ACK_FRAME && frame.type != CONGESTION_FEEDBACK_FRAME &&

- frame.type != PADDING_FRAME;

+ switch (frame.type) {

+ case ACK_FRAME:

+ case CONGESTION_FEEDBACK_FRAME:

+ case PADDING_FRAME:

+ case STOP_WAITING_FRAME:

+ return false;

+ default:

+ return true;

+ }

}

bool QuicPacketCreator::AddFrame(const QuicFrame& frame,

« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/quic_packet_generator.h » ('j') | no next file with comments »