Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 18037002: Clean up the usage of V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch} (Closed)

Created:
7 years, 5 months ago by haitao.feng
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clean up the usage of V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch} R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -178 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/constants-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/cpu-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/debug-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/frames-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/ic-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/atomicops.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/code-stubs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/execution.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flags.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.cc View 16 chunks +23 lines, -23 lines 0 comments Download
M src/globals.h View 3 chunks +12 lines, -14 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/cpu-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 7 chunks +13 lines, -13 lines 0 comments Download
M src/isolate.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/cpu-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/debug-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/disasm-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/frames-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/platform-tls-mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/strtod.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/cpu-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-hashing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-lockers.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haitao.feng
It seems that we could use #if directly when using the V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch}. As ...
7 years, 5 months ago (2013-06-27 08:56:30 UTC) #1
haitao.feng
Add Paul Lind for the MIPS port.
7 years, 5 months ago (2013-06-28 01:43:46 UTC) #2
Jakob Kummerow
LGTM, I'll land.
7 years, 5 months ago (2013-06-28 10:58:00 UTC) #3
Jakob Kummerow
7 years, 5 months ago (2013-06-28 15:35:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698