Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 180353002: Make getProperty more strict when handling the priority parameter (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make getProperty more strict when handling the priority parameter Make getProperty more strict when handling the priority parameter. Before this patch only a substring search on "important" was done. However CSSOM is quite clear to be more strict : http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty 5. If priority is not the empty string and is not an ASCII case-insensitive match for the string "important", terminate this algorithm. This patch implements that more strict behavior and adds a test. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167883

Patch Set 1 #

Patch Set 2 : Add idl change to distinguish between null and empty string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M LayoutTests/fast/css/shorthand-priority.html View 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/css/shorthand-setProperty-important.html View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/shorthand-setProperty-important-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
rwlbuis
This CL is split out from https://codereview.chromium.org/141243006/ as requested. PTAL :)
6 years, 9 months ago (2014-02-25 22:57:45 UTC) #1
esprehn
6 years, 9 months ago (2014-02-26 01:18:51 UTC) #2
esprehn
lgtm
6 years, 9 months ago (2014-02-26 01:18:57 UTC) #3
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-02-26 01:20:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180353002/20001
6 years, 9 months ago (2014-02-26 04:41:03 UTC) #5
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 9 months ago (2014-02-26 04:41:40 UTC) #6
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 9 months ago (2014-02-26 05:27:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180353002/20001
6 years, 9 months ago (2014-02-26 05:28:10 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-26 09:59:37 UTC) #9
Message was sent while issue was closed.
Change committed as 167883

Powered by Google App Engine
This is Rietveld 408576698