Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: LayoutTests/fast/css/shorthand-priority.html

Issue 180353002: Make getProperty more strict when handling the priority parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add idl change to distinguish between null and empty string Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css/shorthand-setProperty-important.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css/shorthand-priority.html
diff --git a/LayoutTests/fast/css/shorthand-priority.html b/LayoutTests/fast/css/shorthand-priority.html
index 71920d1e4e6c309d643b093bae357d2c40ae3f1a..3990c8a0d076b49e408763b2b9851deb02f46b9a 100644
--- a/LayoutTests/fast/css/shorthand-priority.html
+++ b/LayoutTests/fast/css/shorthand-priority.html
@@ -17,7 +17,7 @@ testContainer.innerHTML = '<div id="test">hello</div>';
e = document.getElementById('test');
// Sanity check.
-e.style.setProperty("border-bottom-style", "solid", "!important");
+e.style.setProperty("border-bottom-style", "solid", "important");
shouldBe("e.style.getPropertyValue('border-bottom-style')", "'solid'");
shouldBe("e.style.getPropertyPriority('border-bottom-style')", "'important'");
@@ -27,7 +27,7 @@ shouldBe("e.style.getPropertyValue('border')", "'20px solid green'");
shouldBe("e.style.getPropertyPriority('border')", "''");
e.style.border = "";
-e.style.setProperty("border", "20px solid green", "!important");
+e.style.setProperty("border", "20px solid green", "important");
shouldBe("e.style.getPropertyValue('border')", "'20px solid green'");
shouldBe("e.style.getPropertyPriority('border')", "'important'");
« no previous file with comments | « no previous file | LayoutTests/fast/css/shorthand-setProperty-important.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698