Cleanup of OpenSSL/NSS implementation of ProofVerfifier release.

net/quic/crypto/crypto_handshake.h

Index: net/quic/crypto/crypto_handshake.h
diff --git a/net/quic/crypto/crypto_handshake.h b/net/quic/crypto/crypto_handshake.h
index e702bb66871924b5bc008d8f8eb2b7b35c96af42..e850a4c1cfe4cb962155ad4643e06d6da33a8a10 100644
--- a/net/quic/crypto/crypto_handshake.h
+++ b/net/quic/crypto/crypto_handshake.h
@@ -268,6 +268,10 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
     // (Note: this does not check the chain or signature.)
     void SetProofValid();
 
+    // If the proof has changed then it needs to be revalidated. Helper function

[wtc, 2013/07/03 19:06:58]

"the proof has changed" is just one reason we need to revalidate the proof.
Another reason is that the server config has changed. Of course, a new server
config comes with a new proof, so "the proof has changed" is strictly speaking
still correct, but a little confusing.

I suggest "the server config or the proof has changed".

[ramant (doing other things), 2013/07/03 20:31:35]

Done.

+    // to keep server_config_valid_and generation_counter_ in sync.

[wtc, 2013/07/03 19:06:58]

Nit: server_config_valid_and => server_config_valid_ and

(Needs a space before "and".)

[ramant (doing other things), 2013/07/03 20:31:35]

Done.

+    void SetProofInvalid();
+
     const std::string& server_config() const;
     const std::string& source_address_token() const;
     const std::vector<std::string>& certs() const;
@@ -287,9 +291,10 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
     bool server_config_valid_;          // True if |server_config_| is correctly
                                         // signed and |certs_| has been
                                         // validated.
-    uint64 generation_counter_;         // Generation counter associated with
-                                        // the |server_config_|, |certs_| and
-                                        // |server_config_sig_| combination.
+    // Generation counter associated with the |server_config_|, |certs_| and
+    // |server_config_sig_| combination. It is incremented whenever we set
+    // server_config_valid_ to false.

[wtc, 2013/07/03 19:06:58]

Nit: it looks a little weird that the comment block style changes. But I guess
it is more convenient to have the full line length available to this comment.

[ramant (doing other things), 2013/07/03 20:31:35]

The above was the reason. Comment was too big.

+    uint64 generation_counter_;
 
     // scfg contains the cached, parsed value of |server_config|.
     mutable scoped_ptr<CryptoHandshakeMessage> scfg_;