Cleanup of OpenSSL/NSS implementation of ProofVerfifier release.

net/quic/crypto/proof_verifier_chromium.cc

Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 7a764b6f03c3706c103e584ba2c9d5554dab8434..a1edc4e9347c56a1aa40ad0a8d43aabcb3d1383b 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -40,10 +40,6 @@ ProofVerifierChromium::ProofVerifierChromium(CertVerifier* cert_verifier,
 
 ProofVerifierChromium::~ProofVerifierChromium() {
   verifier_.reset();
-
-  // Reset object state.
-  callback_.Reset();
-  cert_verify_result_.Reset();

[wtc, 2013/07/03 19:06:58]

Thank you for making this change.  I confirmed that this code was copied
from SSLClientSocketNSS::Disconnect(), where it is necessary to do this.

 }
 
 int ProofVerifierChromium::VerifyProof(const string& hostname,
@@ -76,7 +72,6 @@ int ProofVerifierChromium::VerifyProof(const string& hostname,
   cert_ = X509Certificate::CreateFromDERCertChain(cert_pieces);
   if (!cert_.get()) {
     cert_verify_result_.Reset();

[wtc, 2013/07/03 19:06:58]

This line should be removed, too.

[ramant (doing other things), 2013/07/03 20:31:35]

Done.

-    cert_verify_result_.cert_status = CERT_STATUS_INVALID;
     *error_details = "Failed to create certificate chain";
     DLOG(WARNING) << *error_details;
     return ERR_FAILED;
@@ -149,7 +144,7 @@ int ProofVerifierChromium::DoVerifyCertComplete(int result) {
 
   if (result <= ERR_FAILED) {
     *error_details_ = StringPrintf("Failed to verify certificate chain: %s",
-                                  ErrorToString(result));
+                                   ErrorToString(result));
     DLOG(WARNING) << *error_details_;
     result = ERR_FAILED;
   }